[dpdk-stable] patch 'net/virtio-user: fix return value check' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 8 12:14:57 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/13/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/fed050b4454806c62077fbf51b7a00fc1f8eea34

Thanks.

Kevin Traynor

---
>From fed050b4454806c62077fbf51b7a00fc1f8eea34 Mon Sep 17 00:00:00 2001
From: Chenbo Xia <chenbo.xia at intel.com>
Date: Wed, 10 Apr 2019 02:44:05 +0000
Subject: [PATCH] net/virtio-user: fix return value check

[ upstream commit 1e9868885f2ed388e827e8ce27d4b690c9b2fb90 ]

Fix unchecked return value for fcntl.

Coverity issue: 277210
Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")

Signed-off-by: Chenbo Xia <chenbo.xia at intel.com>
Acked-by: Rami Rosen <ramirose at gmail.com>
Reviewed-by: Jens Freimann <jfreimann at redhat.com>
Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>
---
 drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c
index 2c6eba0a6..0a88d5957 100644
--- a/drivers/net/virtio/virtio_user/vhost_user.c
+++ b/drivers/net/virtio/virtio_user/vhost_user.c
@@ -394,5 +394,8 @@ virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un *un)
 
 	flag = fcntl(fd, F_GETFL);
-	fcntl(fd, F_SETFL, flag | O_NONBLOCK);
+	if (fcntl(fd, F_SETFL, flag | O_NONBLOCK) < 0) {
+		PMD_DRV_LOG(ERR, "fcntl failed, %s", strerror(errno));
+		return -1;
+	}
 
 	return 0;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 11:05:06.618319331 +0100
+++ 0015-net-virtio-user-fix-return-value-check.patch	2019-05-08 11:05:05.790933577 +0100
@@ -1 +1 @@
-From 1e9868885f2ed388e827e8ce27d4b690c9b2fb90 Mon Sep 17 00:00:00 2001
+From fed050b4454806c62077fbf51b7a00fc1f8eea34 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1e9868885f2ed388e827e8ce27d4b690c9b2fb90 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 827a48ad6..4b74bd2d8 100644
+index 2c6eba0a6..0a88d5957 100644
@@ -24 +25 @@
-@@ -395,5 +395,8 @@ virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un *un)
+@@ -394,5 +394,8 @@ virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un *un)


More information about the stable mailing list