[dpdk-stable] patch 'app/testpmd: fix variable use before null check' has been queued to LTS release 18.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/13/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/b717bb833f6927a729d417ff998ead0d9aef9c14

Thanks.

Kevin Traynor

---
>From b717bb833f6927a729d417ff998ead0d9aef9c14 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Mon, 8 Apr 2019 10:46:39 +0100
Subject: [PATCH] app/testpmd: fix variable use before null check

[ upstream commit 17250a2affdf88557911bbff086a00d05960a7ca ]

The value returned from rte_eth_dev_tx_offload_name() function is used
for string comparison before being checked for NULL. Move the NULL check
up to be done first.

Coverity issue: 279438
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Rami Rosen <ramirose at gmail.com>
---
 app/test-pmd/cmdline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5d719a186..a5f1ae693 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -18197,4 +18197,6 @@ search_tx_offload(const char *name)
 	for (bit = 0; bit < sizeof(single_offload) * CHAR_BIT; bit++) {
 		single_name = rte_eth_dev_tx_offload_name(single_offload);
+		if (single_name == NULL)
+			break;
 		if (!strcasecmp(single_name, name)) {
 			found = 1;
@@ -18202,6 +18204,4 @@ search_tx_offload(const char *name)
 		} else if (!strcasecmp(single_name, "UNKNOWN"))
 			break;
-		else if (single_name == NULL)
-			break;
 		single_offload <<= 1;
 	}
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 11:05:07.716528938 +0100
+++ 0038-app-testpmd-fix-variable-use-before-null-check.patch	2019-05-08 11:05:05.847932385 +0100
@@ -1 +1 @@
-From 17250a2affdf88557911bbff086a00d05960a7ca Mon Sep 17 00:00:00 2001
+From b717bb833f6927a729d417ff998ead0d9aef9c14 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 17250a2affdf88557911bbff086a00d05960a7ca ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 0558bc58a..5a10c5f38 100644
+index 5d719a186..a5f1ae693 100644
@@ -24 +25 @@
-@@ -18311,4 +18311,6 @@ search_tx_offload(const char *name)
+@@ -18197,4 +18197,6 @@ search_tx_offload(const char *name)
@@ -31 +32 @@
-@@ -18316,6 +18318,4 @@ search_tx_offload(const char *name)
+@@ -18202,6 +18204,4 @@ search_tx_offload(const char *name)