[dpdk-stable] patch 'compress/zlib: fix error handling' has been queued to LTS release 18.11.3
Kevin Traynor
ktraynor at redhat.com
Thu Sep 5 12:17:03 CEST 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/7dedc1b9ed87e912f66b1cbba3c3108bfa489342
Thanks.
Kevin Traynor
---
>From 7dedc1b9ed87e912f66b1cbba3c3108bfa489342 Mon Sep 17 00:00:00 2001
From: Adam Dybkowski <adamx.dybkowski at intel.com>
Date: Wed, 24 Jul 2019 10:42:46 +0200
Subject: [PATCH] compress/zlib: fix error handling
[ upstream commit ff53baa9cc676249d1c5c514755d77e453a99b51 ]
Add missing return after setting the error status in case of
invalid flush_flag in the operation.
The issue was found by the coverity scan as the fin_flush variable,
not initialized in such case, was used later in the flow.
Coverity issue: 340859
Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue")
Signed-off-by: Adam Dybkowski <adamx.dybkowski at intel.com>
---
drivers/compress/zlib/zlib_pmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 5a4d47d4d..19f9200c2 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -31,4 +31,5 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm)
op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
ZLIB_PMD_ERR("Invalid flush value\n");
+ return;
}
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-09-05 10:36:47.713698241 +0100
+++ 0003-compress-zlib-fix-error-handling.patch 2019-09-05 10:36:47.439702222 +0100
@@ -1 +1 @@
-From ff53baa9cc676249d1c5c514755d77e453a99b51 Mon Sep 17 00:00:00 2001
+From 7dedc1b9ed87e912f66b1cbba3c3108bfa489342 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ff53baa9cc676249d1c5c514755d77e453a99b51 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list