[dpdk-stable] patch 'net/hns3: fix link status on failed query' has been queued to stable release 19.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Feb 11 12:20:28 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From bfd523f593e5467b852d992f5ca3bd78a656e7fc Mon Sep 17 00:00:00 2001
From: "Wei Hu (Xavier)" <xavier.huwei at huawei.com>
Date: Thu, 9 Jan 2020 11:15:58 +0800
Subject: [PATCH] net/hns3: fix link status on failed query

[ upstream commit eee015976b46af8cc218263b97f90e8a5937707c ]

Currently, the hns3 PMD driver issues command to the firmware and gets
link status information.

When the driver fails to call internal interface function named
hns3_cmd_send to query the status from firmware for some reason, the
link status queried by the driver should be down.

Fixes: 59fad0f32135 ("net/hns3: support link update operation")

Signed-off-by: Hongbo Zheng <zhenghongbo3 at huawei.com>
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
---
 drivers/net/hns3/hns3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index f41a2fefd8..7e601b8bf8 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -3786,7 +3786,7 @@ hns3_get_mac_link_status(struct hns3_hw *hw)
 	ret = hns3_cmd_send(hw, &desc, 1);
 	if (ret) {
 		hns3_err(hw, "get link status cmd failed %d", ret);
-		return ret;
+		return ETH_LINK_DOWN;
 	}
 
 	req = (struct hns3_link_status_cmd *)desc.data;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-11 11:17:41.809476826 +0000
+++ 0082-net-hns3-fix-link-status-on-failed-query.patch	2020-02-11 11:17:38.520003591 +0000
@@ -1,8 +1,10 @@
-From eee015976b46af8cc218263b97f90e8a5937707c Mon Sep 17 00:00:00 2001
+From bfd523f593e5467b852d992f5ca3bd78a656e7fc Mon Sep 17 00:00:00 2001
 From: "Wei Hu (Xavier)" <xavier.huwei at huawei.com>
 Date: Thu, 9 Jan 2020 11:15:58 +0800
 Subject: [PATCH] net/hns3: fix link status on failed query
 
+[ upstream commit eee015976b46af8cc218263b97f90e8a5937707c ]
+
 Currently, the hns3 PMD driver issues command to the firmware and gets
 link status information.
 
@@ -11,7 +13,6 @@
 link status queried by the driver should be down.
 
 Fixes: 59fad0f32135 ("net/hns3: support link update operation")
-Cc: stable at dpdk.org
 
 Signed-off-by: Hongbo Zheng <zhenghongbo3 at huawei.com>
 Signed-off-by: Huisong Li <lihuisong at huawei.com>
@@ -21,10 +22,10 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
-index b05a557814..9866d147be 100644
+index f41a2fefd8..7e601b8bf8 100644
 --- a/drivers/net/hns3/hns3_ethdev.c
 +++ b/drivers/net/hns3/hns3_ethdev.c
-@@ -3836,7 +3836,7 @@ hns3_get_mac_link_status(struct hns3_hw *hw)
+@@ -3786,7 +3786,7 @@ hns3_get_mac_link_status(struct hns3_hw *hw)
  	ret = hns3_cmd_send(hw, &desc, 1);
  	if (ret) {
  		hns3_err(hw, "get link status cmd failed %d", ret);


More information about the stable mailing list