[dpdk-stable] patch 'net/bnxt: fix unnecessary delay in port stop' has been queued to stable release 19.11.1

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From dc997c7fc2a0b857c2a6ffea0990a56a05366933 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Thu, 6 Feb 2020 22:03:08 +0530
Subject: [PATCH] net/bnxt: fix unnecessary delay in port stop

[ upstream commit 967a722be08cacdd05e6a29d2e1790d5747a6217 ]

VFs and multifunction PFs do not have the privilege to change
link configuration. We force the physical link down as a part
of device stop only for single physical function(SPF).

This change also helps in eliminating the logs when a VF port
is stopped:

"Port 0: link state change event"
"bnxt_print_link_info(): Port 0 Link Up - speed 25000 Mbps - full-duplex"

Fixes: 316e412299fd ("net/bnxt: fix crash when closing")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index cfe3ac2c39..778bdf9367 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -934,9 +934,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
 	bnxt_dev_set_link_down_op(eth_dev);
 
 	/* Wait for link to be reset and the async notification to process.
-	 * During reset recovery, there is no need to wait
+	 * During reset recovery, there is no need to wait and
+	 * VF/NPAR functions do not have privilege to change PHY config.
 	 */
-	if (!is_bnxt_in_error(bp))
+	if (!is_bnxt_in_error(bp) && BNXT_SINGLE_PF(bp))
 		bnxt_link_update(eth_dev, 1, ETH_LINK_DOWN);
 
 	/* Clean queue intr-vector mapping */
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-17 17:00:15.824206668 +0000
+++ 0018-net-bnxt-fix-unnecessary-delay-in-port-stop.patch	2020-02-17 17:00:15.291950228 +0000
@@ -1,8 +1,10 @@
-From 967a722be08cacdd05e6a29d2e1790d5747a6217 Mon Sep 17 00:00:00 2001
+From dc997c7fc2a0b857c2a6ffea0990a56a05366933 Mon Sep 17 00:00:00 2001
 From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
 Date: Thu, 6 Feb 2020 22:03:08 +0530
 Subject: [PATCH] net/bnxt: fix unnecessary delay in port stop
 
+[ upstream commit 967a722be08cacdd05e6a29d2e1790d5747a6217 ]
+
 VFs and multifunction PFs do not have the privilege to change
 link configuration. We force the physical link down as a part
 of device stop only for single physical function(SPF).
@@ -14,7 +16,6 @@
 "bnxt_print_link_info(): Port 0 Link Up - speed 25000 Mbps - full-duplex"
 
 Fixes: 316e412299fd ("net/bnxt: fix crash when closing")
-Cc: stable at dpdk.org
 
 Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
 Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
@@ -24,10 +25,10 @@
  1 file changed, 3 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
-index c1cb40160b..537820960e 100644
+index cfe3ac2c39..778bdf9367 100644
 --- a/drivers/net/bnxt/bnxt_ethdev.c
 +++ b/drivers/net/bnxt/bnxt_ethdev.c
-@@ -948,9 +948,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
+@@ -934,9 +934,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
  	bnxt_dev_set_link_down_op(eth_dev);
  
  	/* Wait for link to be reset and the async notification to process.