[dpdk-stable] patch 'net/qede: do not stop vport if not started' has been queued to stable release 19.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Feb 27 10:33:26 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/29/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 7453074ee57c72795ce2cc70268181631c8714d0 Mon Sep 17 00:00:00 2001
From: Manish Chopra <manishc at marvell.com>
Date: Thu, 6 Feb 2020 12:01:46 -0800
Subject: [PATCH] net/qede: do not stop vport if not started

[ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ]

Stopping an already disabled vport leads to firmware
assert. Stop the vport only if it was started.

Fixes: 2ea6f76aff40 ("qede: add core driver")

Signed-off-by: Manish Chopra <manishc at marvell.com>
Signed-off-by: Rasesh Mody <rmody at marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 19d2e96191..e01d437f19 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1472,7 +1472,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
 	if (eth_dev->data->dev_started)
 		qede_dev_stop(eth_dev);
 
-	qede_stop_vport(edev);
+	if (qdev->vport_started)
+		qede_stop_vport(edev);
 	qdev->vport_started = false;
 	qede_fdir_dealloc_resc(eth_dev);
 	qede_dealloc_fp_resc(eth_dev);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-27 09:31:56.051999658 +0000
+++ 0006-net-qede-do-not-stop-vport-if-not-started.patch	2020-02-27 09:31:55.663945346 +0000
@@ -1,13 +1,14 @@
-From bf44e27af5a4840b2965c71a89eccfc01b5c58bf Mon Sep 17 00:00:00 2001
+From 7453074ee57c72795ce2cc70268181631c8714d0 Mon Sep 17 00:00:00 2001
 From: Manish Chopra <manishc at marvell.com>
 Date: Thu, 6 Feb 2020 12:01:46 -0800
 Subject: [PATCH] net/qede: do not stop vport if not started
 
+[ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ]
+
 Stopping an already disabled vport leads to firmware
 assert. Stop the vport only if it was started.
 
 Fixes: 2ea6f76aff40 ("qede: add core driver")
-Cc: stable at dpdk.org
 
 Signed-off-by: Manish Chopra <manishc at marvell.com>
 Signed-off-by: Rasesh Mody <rmody at marvell.com>
@@ -16,10 +17,10 @@
  1 file changed, 2 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
-index 500440c2ca..74dfe895ad 100644
+index 19d2e96191..e01d437f19 100644
 --- a/drivers/net/qede/qede_ethdev.c
 +++ b/drivers/net/qede/qede_ethdev.c
-@@ -1509,7 +1509,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
+@@ -1472,7 +1472,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
  	if (eth_dev->data->dev_started)
  		qede_dev_stop(eth_dev);
  


More information about the stable mailing list