[dpdk-stable] patch 'net/qede: do not stop vport if not started' has been queued to LTS release 18.11.7

Kevin Traynor ktraynor at redhat.com
Thu Feb 27 18:37:55 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/d94e39f6f4635ddd7157afb0651310a2f0810ddd

Thanks.

Kevin.

---
>From d94e39f6f4635ddd7157afb0651310a2f0810ddd Mon Sep 17 00:00:00 2001
From: Manish Chopra <manishc at marvell.com>
Date: Thu, 6 Feb 2020 12:01:46 -0800
Subject: [PATCH] net/qede: do not stop vport if not started

[ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ]

Stopping an already disabled vport leads to firmware
assert. Stop the vport only if it was started.

Fixes: 2ea6f76aff40 ("qede: add core driver")

Signed-off-by: Manish Chopra <manishc at marvell.com>
Signed-off-by: Rasesh Mody <rmody at marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index c8291839c5..49f7b32056 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1443,5 +1443,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
 		qede_dev_stop(eth_dev);
 
-	qede_stop_vport(edev);
+	if (qdev->vport_started)
+		qede_stop_vport(edev);
 	qdev->vport_started = false;
 	qede_fdir_dealloc_resc(eth_dev);
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-27 17:26:23.908283210 +0000
+++ 0004-net-qede-do-not-stop-vport-if-not-started.patch	2020-02-27 17:26:23.615831825 +0000
@@ -1 +1 @@
-From bf44e27af5a4840b2965c71a89eccfc01b5c58bf Mon Sep 17 00:00:00 2001
+From d94e39f6f4635ddd7157afb0651310a2f0810ddd Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 500440c2ca..74dfe895ad 100644
+index c8291839c5..49f7b32056 100644
@@ -22 +23 @@
-@@ -1510,5 +1510,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
+@@ -1443,5 +1443,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)



More information about the stable mailing list