[dpdk-stable] patch 'net: fix IPv4 checksum' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Fri Jul 17 18:31:56 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/23/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/e0b3cc68e52cfa4d9ddabc7737ab2404d109d1df

Thanks.

Kevin.

---
>From e0b3cc68e52cfa4d9ddabc7737ab2404d109d1df Mon Sep 17 00:00:00 2001
From: Hongzhi Guo <guohongzhi1 at huawei.com>
Date: Tue, 26 May 2020 18:08:05 +0800
Subject: [PATCH] net: fix IPv4 checksum
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 06602c671a5ee23f517456424b216b2427c4334c ]

0xffff is invalid for IPv4 checksum (RFC1624)

Fixes: 6006818cfb26 ("net: new checksum functions")

Signed-off-by: Hongzhi Guo <guohongzhi1 at huawei.com>
Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz at 6wind.com>
---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 7639164c2e..2c78ba6cf6 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -260,5 +260,5 @@ rte_ipv4_cksum(const struct ipv4_hdr *ipv4_hdr)
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-17 17:17:00.441604102 +0100
+++ 0008-net-fix-IPv4-checksum.patch	2020-07-17 17:16:59.964771768 +0100
@@ -1 +1 @@
-From 06602c671a5ee23f517456424b216b2427c4334c Mon Sep 17 00:00:00 2001
+From e0b3cc68e52cfa4d9ddabc7737ab2404d109d1df Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 06602c671a5ee23f517456424b216b2427c4334c ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 4c4437a547..292f63fd74 100644
+index 7639164c2e..2c78ba6cf6 100644
@@ -25 +26 @@
-@@ -268,5 +268,5 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
+@@ -260,5 +260,5 @@ rte_ipv4_cksum(const struct ipv4_hdr *ipv4_hdr)
@@ -27 +28 @@
- 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
+ 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct ipv4_hdr));



More information about the stable mailing list