[dpdk-stable] patch 'service: fix lcore iteration' has been queued to stable release 19.11.4

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From eceee0c93bfb15a0cf3480c9fd96ac01fafb8edc Mon Sep 17 00:00:00 2001
From: Igor Romanov <igor.romanov at oktetlabs.ru>
Date: Tue, 7 Jul 2020 11:45:24 +0100
Subject: [PATCH] service: fix lcore iteration

[ upstream commit f3c256b621262e581d3edcca383df83875ab7ebe ]

The service core list is populated, but not used. Incorrect
lcore states are examined for a service.

Use the populated list to iterate over service cores.

Fixes: e484ccddbe1b ("service: avoid false sharing on core state")

Signed-off-by: Igor Romanov <igor.romanov at oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
---
 lib/librte_eal/common/rte_service.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index d5dd32d8d..eca6ccc59 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -397,7 +397,7 @@ rte_service_may_be_active(uint32_t id)
 		return -EINVAL;
 
 	for (i = 0; i < lcore_count; i++) {
-		if (lcore_states[i].service_active_on_lcore[id])
+		if (lcore_states[ids[i]].service_active_on_lcore[id])
 			return 1;
 	}
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-24 12:53:52.054228510 +0100
+++ 0091-service-fix-lcore-iteration.patch	2020-07-24 12:53:48.315006981 +0100
@@ -1,15 +1,16 @@
-From f3c256b621262e581d3edcca383df83875ab7ebe Mon Sep 17 00:00:00 2001
+From eceee0c93bfb15a0cf3480c9fd96ac01fafb8edc Mon Sep 17 00:00:00 2001
 From: Igor Romanov <igor.romanov at oktetlabs.ru>
 Date: Tue, 7 Jul 2020 11:45:24 +0100
 Subject: [PATCH] service: fix lcore iteration
 
+[ upstream commit f3c256b621262e581d3edcca383df83875ab7ebe ]
+
 The service core list is populated, but not used. Incorrect
 lcore states are examined for a service.
 
 Use the populated list to iterate over service cores.
 
 Fixes: e484ccddbe1b ("service: avoid false sharing on core state")
-Cc: stable at dpdk.org
 
 Signed-off-by: Igor Romanov <igor.romanov at oktetlabs.ru>
 Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
@@ -20,10 +21,10 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
-index 6123a2124..e2795f857 100644
+index d5dd32d8d..eca6ccc59 100644
 --- a/lib/librte_eal/common/rte_service.c
 +++ b/lib/librte_eal/common/rte_service.c
-@@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id)
+@@ -397,7 +397,7 @@ rte_service_may_be_active(uint32_t id)
  		return -EINVAL;
  
  	for (i = 0; i < lcore_count; i++) {