[dpdk-stable] patch 'net/dpaa2: fix 10G port negotiation' has been queued to LTS release 18.11.9
Kevin Traynor
ktraynor at redhat.com
Fri Jun 5 20:24:38 CEST 2020
Hi,
FYI, your patch has been queued to LTS release 18.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/10/20. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/d2a2e4d347c293888a070a5e3f6e267cd914e525
Thanks.
Kevin.
---
>From d2a2e4d347c293888a070a5e3f6e267cd914e525 Mon Sep 17 00:00:00 2001
From: Rohit Raj <rohit.raj at nxp.com>
Date: Fri, 8 May 2020 18:32:03 +0530
Subject: [PATCH] net/dpaa2: fix 10G port negotiation
[ upstream commit 7e6ecac281e4571d942889d6de687bb87623899b ]
Fixed 10G port negotiation issue with another 10G/non 10G port.
When running testpmd with 10G interfaces on 10BaseT interface
on LS2088ARDB, the ports were showing link as down.
This was identified to be caused by the setting of link as down
during config.
Also, the line rate was not being updated in device link params,
thus having the incorrect link speed in status (as 0).
Fixes: c5acbb5ea20e ("net/dpaa2: support link status event")
Signed-off-by: Rohit Raj <rohit.raj at nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
drivers/net/dpaa2/dpaa2_ethdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index e50467285e..c801d922cf 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -437,7 +437,4 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
- /* update the current status */
- dpaa2_dev_link_update(dev, 0);
-
return 0;
}
@@ -1481,4 +1478,5 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
dev->tx_pkt_burst = dpaa2_dev_tx;
dev->data->dev_link.link_status = state.up;
+ dev->data->dev_link.link_speed = state.rate;
if (state.up)
--
2.21.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2020-06-05 19:20:53.102357569 +0100
+++ 0041-net-dpaa2-fix-10G-port-negotiation.patch 2020-06-05 19:20:50.819040609 +0100
@@ -1 +1 @@
-From 7e6ecac281e4571d942889d6de687bb87623899b Mon Sep 17 00:00:00 2001
+From d2a2e4d347c293888a070a5e3f6e267cd914e525 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7e6ecac281e4571d942889d6de687bb87623899b ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index 2cde55e7cc..4fc550a885 100644
+index e50467285e..c801d922cf 100644
@@ -29 +30 @@
-@@ -554,7 +554,4 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
+@@ -437,7 +437,4 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
@@ -37 +38 @@
-@@ -1758,4 +1755,5 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
+@@ -1481,4 +1478,5 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
More information about the stable
mailing list