[dpdk-stable] patch 'net/i40e: fix X722 performance' has been queued to stable release 19.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue May 19 14:53:31 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 2ce209609212398be82eb193c94264e85e766e6f Mon Sep 17 00:00:00 2001
From: Qiming Yang <qiming.yang at intel.com>
Date: Tue, 3 Mar 2020 13:45:00 +0800
Subject: [PATCH] net/i40e: fix X722 performance

[ upstream commit b4668579286c56fded2816602e104abbcf0b5adb ]

Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't
reach line rate in one queue one core forwarding case. It's about 1%
performance drop.  This patch adds value as:

 Device-ID  Value        Comments
 0x37D0    0x03030303   4x10G FPK

This value is hardware specific.

Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")

Signed-off-by: Qiming Yang <qiming.yang at intel.com>
Acked-by: Xiaolong Ye <xiaolong.ye at intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 86fc4f4076..55ba606f85 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10408,6 +10408,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
 		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },
+		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) },
 
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) },
 		{ I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) },
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 13:56:19.661758188 +0100
+++ 0021-net-i40e-fix-X722-performance.patch	2020-05-19 13:56:18.203501531 +0100
@@ -1,8 +1,10 @@
-From b4668579286c56fded2816602e104abbcf0b5adb Mon Sep 17 00:00:00 2001
+From 2ce209609212398be82eb193c94264e85e766e6f Mon Sep 17 00:00:00 2001
 From: Qiming Yang <qiming.yang at intel.com>
 Date: Tue, 3 Mar 2020 13:45:00 +0800
 Subject: [PATCH] net/i40e: fix X722 performance
 
+[ upstream commit b4668579286c56fded2816602e104abbcf0b5adb ]
+
 Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't
 reach line rate in one queue one core forwarding case. It's about 1%
 performance drop.  This patch adds value as:
@@ -13,7 +15,6 @@
 This value is hardware specific.
 
 Fixes: 3320d4a240da ("net/i40e: workaround performance degradation")
-Cc: stable at dpdk.org
 
 Signed-off-by: Qiming Yang <qiming.yang at intel.com>
 Acked-by: Xiaolong Ye <xiaolong.ye at intel.com>
@@ -22,10 +23,10 @@
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
-index 9fbda1c34c..c09b9b990c 100644
+index 86fc4f4076..55ba606f85 100644
 --- a/drivers/net/i40e/i40e_ethdev.c
 +++ b/drivers/net/i40e/i40e_ethdev.c
-@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
+@@ -10408,6 +10408,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)
  		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) },
  		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) },
  		{ I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },


More information about the stable mailing list