[dpdk-stable] patch 'net/virtio: fix outdated comment' has been queued to stable release 19.11.3
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue May 19 15:03:26 CEST 2020
Hi,
FYI, your patch has been queued to stable release 19.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Luca Boccassi
---
>From 871773f3ac2889e365f7483311b3814b9c54ffad Mon Sep 17 00:00:00 2001
From: Xiaolong Ye <xiaolong.ye at intel.com>
Date: Sat, 7 Mar 2020 21:22:34 +0800
Subject: [PATCH] net/virtio: fix outdated comment
[ upstream commit f6ac14f13b040fb44db6ed4ab392865fb6648201 ]
Fix comment that is no more correct as the code evolved.
Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")
Signed-off-by: Xiaolong Ye <xiaolong.ye at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
drivers/net/virtio/virtio_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index f9d0ea70db..35203940a7 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
}
if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) {
- PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2");
+ PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2");
return -EINVAL;
}
@@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
hw->cvq = cvq;
}
- /* For virtio_user case (that is when hw->dev is NULL), we use
- * virtual address. And we need properly set _offset_, please see
+ /* For virtio_user case (that is when hw->virtio_user_dev is not NULL),
+ * we use virtual address. And we need properly set _offset_, please see
* VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information.
*/
if (!hw->virtio_user_dev)
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2020-05-19 14:04:47.371982751 +0100
+++ 0071-net-virtio-fix-outdated-comment.patch 2020-05-19 14:04:44.232648662 +0100
@@ -1,12 +1,13 @@
-From f6ac14f13b040fb44db6ed4ab392865fb6648201 Mon Sep 17 00:00:00 2001
+From 871773f3ac2889e365f7483311b3814b9c54ffad Mon Sep 17 00:00:00 2001
From: Xiaolong Ye <xiaolong.ye at intel.com>
Date: Sat, 7 Mar 2020 21:22:34 +0800
Subject: [PATCH] net/virtio: fix outdated comment
+[ upstream commit f6ac14f13b040fb44db6ed4ab392865fb6648201 ]
+
Fix comment that is no more correct as the code evolved.
Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")
-Cc: stable at dpdk.org
Signed-off-by: Xiaolong Ye <xiaolong.ye at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
More information about the stable
mailing list