[dpdk-stable] patch 'net/bnxt: fix port start failure handling' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From a62880c4d4ae861422c966ebbbb33082e474ddc1 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Tue, 21 Apr 2020 14:33:48 -0700
Subject: [PATCH] net/bnxt: fix port start failure handling

[ upstream commit cf2445374c573bdbccb8144962367cb21e99e58e ]

Fixed to invoke clean up in the reverse sequence of
initialization in case any of the FW commands fail
during port start.

Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ed88b594df..cddcd427df 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -891,10 +891,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
 	return 0;
 
 error:
-	bnxt_hwrm_if_change(bp, false);
 	bnxt_shutdown_nic(bp);
 	bnxt_free_tx_mbufs(bp);
 	bnxt_free_rx_mbufs(bp);
+	bnxt_hwrm_if_change(bp, false);
 	eth_dev->data->dev_started = 0;
 	return rc;
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:49.133136338 +0100
+++ 0114-net-bnxt-fix-port-start-failure-handling.patch	2020-05-19 14:04:44.384651418 +0100
@@ -1,14 +1,15 @@
-From cf2445374c573bdbccb8144962367cb21e99e58e Mon Sep 17 00:00:00 2001
+From a62880c4d4ae861422c966ebbbb33082e474ddc1 Mon Sep 17 00:00:00 2001
 From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
 Date: Tue, 21 Apr 2020 14:33:48 -0700
 Subject: [PATCH] net/bnxt: fix port start failure handling
 
+[ upstream commit cf2445374c573bdbccb8144962367cb21e99e58e ]
+
 Fixed to invoke clean up in the reverse sequence of
 initialization in case any of the FW commands fail
 during port start.
 
 Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes")
-Cc: stable at dpdk.org
 
 Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
 Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
@@ -18,10 +19,10 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
-index 780d9c46e9..206111db5b 100644
+index ed88b594df..cddcd427df 100644
 --- a/drivers/net/bnxt/bnxt_ethdev.c
 +++ b/drivers/net/bnxt/bnxt_ethdev.c
-@@ -1113,10 +1113,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
+@@ -891,10 +891,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
  	return 0;
  
  error: