[dpdk-stable] patch 'net/avp: fix gcc 10 maybe-uninitialized warning' has been queued to stable release 19.11.3
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue May 19 15:04:26 CEST 2020
Hi,
FYI, your patch has been queued to stable release 19.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Luca Boccassi
---
>From ea0fb3e5a5ba8b9aed88471c969ad56583c88470 Mon Sep 17 00:00:00 2001
From: Kevin Traynor <ktraynor at redhat.com>
Date: Wed, 11 Mar 2020 11:32:59 +0000
Subject: [PATCH] net/avp: fix gcc 10 maybe-uninitialized warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[ upstream commit ec87d3b2c2451ce0fa71f53f64987c68a0b3423c ]
gcc 10.0.1 reports:
../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’:
../drivers/net/avp/avp_ethdev.c:1791:24:
warning: ‘avp_bufs[count]’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
1791 | tx_bufs[i] = avp_bufs[count];
| ~~~~~~~~^~~~~~~
../drivers/net/avp/avp_ethdev.c:1791:24:
warning: ‘avp_bufs[count]’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
Fix by initializing the array.
Fixes: 295abce2d25b ("net/avp: add packet transmit functions")
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Steven Webster <steven.webster at windriver.com>
---
drivers/net/avp/avp_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index cd747b6beb..1abe96ce50 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -1694,7 +1694,7 @@ avp_xmit_scattered_pkts(void *tx_queue,
uint16_t nb_pkts)
{
struct rte_avp_desc *avp_bufs[(AVP_MAX_TX_BURST *
- RTE_AVP_MAX_MBUF_SEGMENTS)];
+ RTE_AVP_MAX_MBUF_SEGMENTS)] = {};
struct avp_queue *txq = (struct avp_queue *)tx_queue;
struct rte_avp_desc *tx_bufs[AVP_MAX_TX_BURST];
struct avp_dev *avp = txq->avp;
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2020-05-19 14:04:49.797286310 +0100
+++ 0131-net-avp-fix-gcc-10-maybe-uninitialized-warning.patch 2020-05-19 14:04:44.444652506 +0100
@@ -1,4 +1,4 @@
-From ec87d3b2c2451ce0fa71f53f64987c68a0b3423c Mon Sep 17 00:00:00 2001
+From ea0fb3e5a5ba8b9aed88471c969ad56583c88470 Mon Sep 17 00:00:00 2001
From: Kevin Traynor <ktraynor at redhat.com>
Date: Wed, 11 Mar 2020 11:32:59 +0000
Subject: [PATCH] net/avp: fix gcc 10 maybe-uninitialized warning
@@ -6,6 +6,8 @@
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
+[ upstream commit ec87d3b2c2451ce0fa71f53f64987c68a0b3423c ]
+
gcc 10.0.1 reports:
../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’:
@@ -21,7 +23,6 @@
Fix by initializing the array.
Fixes: 295abce2d25b ("net/avp: add packet transmit functions")
-Cc: stable at dpdk.org
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Steven Webster <steven.webster at windriver.com>
More information about the stable
mailing list