[dpdk-stable] patch 'net/thunderx: use dynamic log type' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Thu May 28 18:22:38 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/03/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/989e1816ae51560bb07f60d42adb86cca98db845

Thanks.

Kevin.

---
>From 989e1816ae51560bb07f60d42adb86cca98db845 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Mon, 30 Mar 2020 21:41:56 -0700
Subject: [PATCH] net/thunderx: use dynamic log type

[ upstream commit d801c39559b346f26e3d3a8e16a92bb19e0165b9 ]

The PMD static logtype is original DPDK legacy and should not be used.

Fixes: 43362c6a7647 ("net/thunderx: support RSS and RETA query and update")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/thunderx/nicvf_ethdev.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index ae5a33e3a1..d627a3bb70 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -489,7 +489,8 @@ nicvf_dev_reta_query(struct rte_eth_dev *dev,
 
 	if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) {
-		RTE_LOG(ERR, PMD, "The size of hash lookup table configured "
-			"(%d) doesn't match the number hardware can supported "
-			"(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
+		PMD_DRV_LOG(ERR,
+			    "The size of hash lookup table configured "
+			    "(%u) doesn't match the number hardware can supported "
+			    "(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
 		return -EINVAL;
 	}
@@ -519,7 +520,7 @@ nicvf_dev_reta_update(struct rte_eth_dev *dev,
 
 	if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) {
-		RTE_LOG(ERR, PMD, "The size of hash lookup table configured "
-			"(%d) doesn't match the number hardware can supported "
-			"(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
+		PMD_DRV_LOG(ERR, "The size of hash lookup table configured "
+			"(%u) doesn't match the number hardware can supported "
+			"(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
 		return -EINVAL;
 	}
@@ -562,6 +563,6 @@ nicvf_dev_rss_hash_update(struct rte_eth_dev *dev,
 	if (rss_conf->rss_key &&
 		rss_conf->rss_key_len != RSS_HASH_KEY_BYTE_SIZE) {
-		RTE_LOG(ERR, PMD, "Hash key size mismatch %d",
-				rss_conf->rss_key_len);
+		PMD_DRV_LOG(ERR, "Hash key size mismatch %u",
+			    rss_conf->rss_key_len);
 		return -EINVAL;
 	}
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-28 17:13:01.767252438 +0100
+++ 0051-net-thunderx-use-dynamic-log-type.patch	2020-05-28 17:12:59.123555903 +0100
@@ -1 +1 @@
-From d801c39559b346f26e3d3a8e16a92bb19e0165b9 Mon Sep 17 00:00:00 2001
+From 989e1816ae51560bb07f60d42adb86cca98db845 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d801c39559b346f26e3d3a8e16a92bb19e0165b9 ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 6f43541a5d..bfda0ab0ed 100644
+index ae5a33e3a1..d627a3bb70 100644
@@ -21 +22 @@
-@@ -497,7 +497,8 @@ nicvf_dev_reta_query(struct rte_eth_dev *dev,
+@@ -489,7 +489,8 @@ nicvf_dev_reta_query(struct rte_eth_dev *dev,
@@ -33 +34 @@
-@@ -527,7 +528,7 @@ nicvf_dev_reta_update(struct rte_eth_dev *dev,
+@@ -519,7 +520,7 @@ nicvf_dev_reta_update(struct rte_eth_dev *dev,
@@ -44 +45 @@
-@@ -570,6 +571,6 @@ nicvf_dev_rss_hash_update(struct rte_eth_dev *dev,
+@@ -562,6 +563,6 @@ nicvf_dev_rss_hash_update(struct rte_eth_dev *dev,



More information about the stable mailing list