[dpdk-stable] patch 'common/mlx5: fix DevX SQ object creation' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/11/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/060f17455ae84de71cd072cf2fdeb9a8536e087e

Thanks.

Luca Boccassi

---
>From 060f17455ae84de71cd072cf2fdeb9a8536e087e Mon Sep 17 00:00:00 2001
From: Tal Shnaiderman <talshn at nvidia.com>
Date: Mon, 26 Oct 2020 20:17:48 +0200
Subject: [PATCH] common/mlx5: fix DevX SQ object creation

[ upstream commit 1912d158e1db1098fb81982dbb6013c213326837 ]

Fix wrong assignment of allow_multi_pkt_send_wqe
in mlx5_devx_cmd_create_sq.
The incorrect assignment was introduced in the initial
mlx5_devx_cmd_create_sq implementation.

sq_attr->flush_in_error_en is
mistakenly assigned to both allow_multi_pkt_send_wqe and
flush_in_error_en, it was detected during Windows PMD development.

The fix is simply assigning the right value in mlx5_devx_cmd_create_sq
to sq_attr->allow_multi_pkt_send_wqe

Fixes: ae18a1ae9692 ("net/mlx5: support Tx hairpin queues")

Signed-off-by: Tal Shnaiderman <talshn at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
 drivers/net/mlx5/mlx5_devx_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_devx_cmds.c b/drivers/net/mlx5/mlx5_devx_cmds.c
index e223ee9b18..f9c4043c11 100644
--- a/drivers/net/mlx5/mlx5_devx_cmds.c
+++ b/drivers/net/mlx5/mlx5_devx_cmds.c
@@ -778,7 +778,7 @@ mlx5_devx_cmd_create_sq(struct ibv_context *ctx,
 	MLX5_SET(sqc, sq_ctx, fre, sq_attr->fre);
 	MLX5_SET(sqc, sq_ctx, flush_in_error_en, sq_attr->flush_in_error_en);
 	MLX5_SET(sqc, sq_ctx, allow_multi_pkt_send_wqe,
-		 sq_attr->flush_in_error_en);
+		 sq_attr->allow_multi_pkt_send_wqe);
 	MLX5_SET(sqc, sq_ctx, min_wqe_inline_mode,
 		 sq_attr->min_wqe_inline_mode);
 	MLX5_SET(sqc, sq_ctx, state, sq_attr->state);
-- 
2.27.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-09 18:40:13.829205057 +0000
+++ 0071-common-mlx5-fix-DevX-SQ-object-creation.patch	2020-11-09 18:40:11.215312589 +0000
@@ -1 +1 @@
-From 1912d158e1db1098fb81982dbb6013c213326837 Mon Sep 17 00:00:00 2001
+From 060f17455ae84de71cd072cf2fdeb9a8536e087e Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1912d158e1db1098fb81982dbb6013c213326837 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
+ drivers/net/mlx5/mlx5_devx_cmds.c | 2 +-
@@ -27,5 +28,5 @@
-diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
-index 5b0f8a8654..a13febebfd 100644
---- a/drivers/common/mlx5/mlx5_devx_cmds.c
-+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
-@@ -1333,7 +1333,7 @@ mlx5_devx_cmd_create_sq(void *ctx,
+diff --git a/drivers/net/mlx5/mlx5_devx_cmds.c b/drivers/net/mlx5/mlx5_devx_cmds.c
+index e223ee9b18..f9c4043c11 100644
+--- a/drivers/net/mlx5/mlx5_devx_cmds.c
++++ b/drivers/net/mlx5/mlx5_devx_cmds.c
+@@ -778,7 +778,7 @@ mlx5_devx_cmd_create_sq(struct ibv_context *ctx,