[dpdk-stable] patch 'app/testpmd: do not allow dynamic change of core number' has been queued to LTS release 18.11.11

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/24/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/266047e5921bb30d4f60ffa3c746f81453bf62b9

Thanks.

Kevin.

---
>From 266047e5921bb30d4f60ffa3c746f81453bf62b9 Mon Sep 17 00:00:00 2001
From: Zhenghua Zhou <zhenghuax.zhou at intel.com>
Date: Tue, 27 Oct 2020 06:42:52 +0000
Subject: [PATCH] app/testpmd: do not allow dynamic change of core number

[ upstream commit 653c6ed4a12ad40e476a8936b4f463e01acfbf78 ]

When the number of forwarding cores changed in runtime, the issue may
be encountered:
If the nbcore set little than current nbcore, the forwarding thread
will still running on the extra cores. Therefore, trying to stop
forwarding will hang testpmd, since it will wait for the extra cores to
stop.

So do not allow to change nbcore number when forwarding is running.

Fixes: 0c0db76f42ed ("app/testpmd: separate forward config setup from display")

Signed-off-by: Zhenghua Zhou <zhenghuax.zhou at intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/config.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index e60f5db33b..7750fe4191 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2507,4 +2507,8 @@ void
 set_fwd_lcores_number(uint16_t nb_lc)
 {
+	if (test_done == 0) {
+		printf("Please stop forwarding first\n");
+		return;
+	}
 	if (nb_lc > nb_cfg_lcores) {
 		printf("nb fwd cores %u > %u (max. number of configured "
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-18 16:33:39.207639086 +0000
+++ 0068-app-testpmd-do-not-allow-dynamic-change-of-core-numb.patch	2020-11-18 16:33:37.996215105 +0000
@@ -1 +1 @@
-From 653c6ed4a12ad40e476a8936b4f463e01acfbf78 Mon Sep 17 00:00:00 2001
+From 266047e5921bb30d4f60ffa3c746f81453bf62b9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 653c6ed4a12ad40e476a8936b4f463e01acfbf78 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 136f4e5dbe..755d1dfc9c 100644
+index e60f5db33b..7750fe4191 100644
@@ -28 +29 @@
-@@ -3505,4 +3505,8 @@ void
+@@ -2507,4 +2507,8 @@ void