[dpdk-stable] patch 'net/mlx5: fix Rx packet padding config via DevX' has been queued to stable release 19.11.6
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Wed Nov 25 10:02:44 CET 2020
Hi,
FYI, your patch has been queued to stable release 19.11.6
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/20. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/7d36191470aad626b69ad3751fbeb86c18ede3a7
Thanks.
Luca Boccassi
---
>From 7d36191470aad626b69ad3751fbeb86c18ede3a7 Mon Sep 17 00:00:00 2001
From: Alexander Kozyrev <akozyrev at nvidia.com>
Date: Sun, 15 Nov 2020 14:25:34 +0000
Subject: [PATCH] net/mlx5: fix Rx packet padding config via DevX
[ upstream commit ff2deada2ed8e1659e8774c42638657aaf77dc5b ]
Received packets can be aligned to the size of the cache line on
PCI transactions. This could improve performance by avoiding
partial cache line writes in exchange for increased PCI bandwidth.
This feature is supposed to be controlled by the rxq_pkt_pad_en
devarg and it is true for an RxQ created via the Verbs API.
But in the DevX API case, it is erroneously controlled by the
rxq_cqe_pad_en devarg instead, which is in charge of the CQE
padding instead and should not control the RxQ creation.
Fix DevX RxQ creation by using the proper configuration flag for
Rx packet padding that is being set by the rxq_pkt_pad_en devarg.
Fixes: dc9ceff73c99 ("net/mlx5: create advanced RxQ via DevX")
Signed-off-by: Alexander Kozyrev <akozyrev at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
drivers/net/mlx5/mlx5_rxq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 5a11325430..f3c2d99c15 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1153,7 +1153,7 @@ static void
mlx5_devx_wq_attr_fill(struct mlx5_priv *priv, struct mlx5_rxq_ctrl *rxq_ctrl,
struct mlx5_devx_wq_attr *wq_attr)
{
- wq_attr->end_padding_mode = priv->config.cqe_pad ?
+ wq_attr->end_padding_mode = priv->config.hw_padding ?
MLX5_WQ_END_PAD_MODE_ALIGN :
MLX5_WQ_END_PAD_MODE_NONE;
wq_attr->pd = priv->sh->pdn;
--
2.27.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2020-11-24 16:50:36.630541342 +0000
+++ 0002-net-mlx5-fix-Rx-packet-padding-config-via-DevX.patch 2020-11-24 16:50:36.533495553 +0000
@@ -1 +1 @@
-From ff2deada2ed8e1659e8774c42638657aaf77dc5b Mon Sep 17 00:00:00 2001
+From 7d36191470aad626b69ad3751fbeb86c18ede3a7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ff2deada2ed8e1659e8774c42638657aaf77dc5b ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
- drivers/net/mlx5/mlx5_devx.c | 2 +-
+ drivers/net/mlx5/mlx5_rxq.c | 2 +-
@@ -28,5 +29,5 @@
-diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
-index e9ceda5caf..34044fcb0c 100644
---- a/drivers/net/mlx5/mlx5_devx.c
-+++ b/drivers/net/mlx5/mlx5_devx.c
-@@ -294,7 +294,7 @@ static void
+diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
+index 5a11325430..f3c2d99c15 100644
+--- a/drivers/net/mlx5/mlx5_rxq.c
++++ b/drivers/net/mlx5/mlx5_rxq.c
+@@ -1153,7 +1153,7 @@ static void
More information about the stable
mailing list