[dpdk-stable] patch 'app/testpmd: revert setting MTU explicitly after configure' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/bdc1ebe7a0f4f8cd646f2f8e3851c1c5976aaa65

Thanks.

Luca Boccassi

---
>From bdc1ebe7a0f4f8cd646f2f8e3851c1c5976aaa65 Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Mon, 16 Nov 2020 19:03:54 +0000
Subject: [PATCH] app/testpmd: revert setting MTU explicitly after configure

[ upstream commit 56f0534311d4c61c63e2455169749ae440278122 ]

Setting MTU after each 'rte_eth_dev_configure()' prevents using
"--max-pkt-len=N" parameter and "port config all max-pkt-len #" command

This is breaking DTS scatter test case which is using
"--max-pkt-len=9000" testpmd parameter.

Reverting workaround to recover the DTS testcase.

Fixes: 1c21ee95cf52 ("app/testpmd: fix MTU after device configure")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Tested-by: Bo Chen <box.c.chen at intel.com>
---
 app/test-pmd/testpmd.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 7b08bd2f59..8d3b7b2a3b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2334,8 +2334,6 @@ start_port(portid_t pid)
 		}
 
 		if (port->need_reconfig > 0) {
-			uint16_t mtu = RTE_ETHER_MTU;
-
 			port->need_reconfig = 0;
 
 			if (flow_isolate_all) {
@@ -2369,23 +2367,6 @@ start_port(portid_t pid)
 				port->need_reconfig = 1;
 				return -1;
 			}
-
-			/*
-			 * Workaround for rte_eth_dev_configure(), max_rx_pkt_len
-			 * set MTU wrong for the PMDs that have frame overhead
-			 * bigger than RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN.
-			 * For a PMD that has 26 bytes overhead, rte_eth_dev_configure()
-			 * can set MTU to max 1492, not to expected 1500 bytes.
-			 * Using rte_eth_dev_set_mtu() to be able to set MTU correctly,
-			 * default MTU value is 1500.
-			 */
-			diag = rte_eth_dev_get_mtu(pi, &mtu);
-			if (diag)
-				printf("Failed to get MTU for port %d\n", pi);
-			diag = rte_eth_dev_set_mtu(pi, mtu);
-			if (diag != 0 && diag != -ENOTSUP)
-				printf("Failed to set MTU to %u for port %d\n",
-						mtu, pi);
 		}
 		if (port->need_reconfig_queues > 0) {
 			port->need_reconfig_queues = 0;
-- 
2.27.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-24 16:50:36.909093974 +0000
+++ 0008-app-testpmd-revert-setting-MTU-explicitly-after-conf.patch	2020-11-24 16:50:36.565496231 +0000
@@ -1 +1 @@
-From 56f0534311d4c61c63e2455169749ae440278122 Mon Sep 17 00:00:00 2001
+From bdc1ebe7a0f4f8cd646f2f8e3851c1c5976aaa65 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 56f0534311d4c61c63e2455169749ae440278122 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 48e9647fc7..33fc0fddf5 100644
+index 7b08bd2f59..8d3b7b2a3b 100644
@@ -27 +28 @@
-@@ -2537,8 +2537,6 @@ start_port(portid_t pid)
+@@ -2334,8 +2334,6 @@ start_port(portid_t pid)
@@ -36 +37 @@
-@@ -2572,23 +2570,6 @@ start_port(portid_t pid)
+@@ -2369,23 +2367,6 @@ start_port(portid_t pid)