[dpdk-stable] patch 'app/testpmd: fix build with gcc 11' has been queued to stable release 19.11.6

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Oct 28 11:44:34 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 96f51e519ac49511a7c61c57b818daa1873d0671 Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Mon, 21 Sep 2020 14:38:29 +0100
Subject: [PATCH] app/testpmd: fix build with gcc 11
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 62aa0e8c6693bb5656b5a9ad5c5248fce9150ee3 ]

Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)

../app/test-pmd/config.c:1777:61:
	warning: argument 3 of type ‘const uint32_t[n]’
	{aka ‘const unsigned int[n]’} declared as a variable length
	array [-Wvla-parameter]
 1777 | port_flow_list(portid_t port_id, uint32_t n,
 			const uint32_t group[n])
      |                 ~~~~~~~~~~~~~~~^~~~~~~~
In file included from ../app/test-pmd/config.c:53:
../app/test-pmd/testpmd.h:764:67:
	note: previously declared as a pointer ‘const uint32_t *’
	{aka ‘const unsigned int *’}
  764 | void port_flow_list(portid_t port_id, uint32_t n,
  				const uint32_t *group);
      |                         ~~~~~~~~~~~~~~~~^~~~~

Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Reviewed-by: Phil Yang <phil.yang at arm.com>
Reviewed-by: Asaf Penso <asafp at nvidia.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 343402f172..124a6b8c57 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1568,7 +1568,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
 
 /** List flow rules. */
 void
-port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
+port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group)
 {
 	struct rte_port *port;
 	struct port_flow *pf;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:15.325632411 +0000
+++ 0115-app-testpmd-fix-build-with-gcc-11.patch	2020-10-28 10:35:11.672832496 +0000
@@ -1,4 +1,4 @@
-From 62aa0e8c6693bb5656b5a9ad5c5248fce9150ee3 Mon Sep 17 00:00:00 2001
+From 96f51e519ac49511a7c61c57b818daa1873d0671 Mon Sep 17 00:00:00 2001
 From: Ferruh Yigit <ferruh.yigit at intel.com>
 Date: Mon, 21 Sep 2020 14:38:29 +0100
 Subject: [PATCH] app/testpmd: fix build with gcc 11
@@ -6,6 +6,8 @@
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 8bit
 
+[ upstream commit 62aa0e8c6693bb5656b5a9ad5c5248fce9150ee3 ]
+
 Error observed with gcc 11 under development
 gcc (GCC) 11.0.0 20200920 (experimental)
 
@@ -25,7 +27,6 @@
       |                         ~~~~~~~~~~~~~~~~^~~~~
 
 Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
 Reviewed-by: David Marchand <david.marchand at redhat.com>
@@ -36,10 +37,10 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
-index 418ea6dda4..e73dc66c8d 100644
+index 343402f172..124a6b8c57 100644
 --- a/app/test-pmd/config.c
 +++ b/app/test-pmd/config.c
-@@ -1896,7 +1896,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
+@@ -1568,7 +1568,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
  
  /** List flow rules. */
  void


More information about the stable mailing list