[dpdk-stable] patch 'raw/ioat: fix missing close function' has been queued to stable release 19.11.6

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Oct 28 11:44:36 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From b0e37c91df43873f22c843875accceb1e11fa83f Mon Sep 17 00:00:00 2001
From: Kevin Laatz <kevin.laatz at intel.com>
Date: Thu, 8 Oct 2020 10:51:10 +0100
Subject: [PATCH] raw/ioat: fix missing close function

[ upstream commit 8c6cedee761c7abd8c3d451bffa7c70747ab7629 ]

When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a
dev_close function for the device causing a segmentation fault when no
close() function is implemented for a driver.

This patch resolves the issue by adding a stub function ioat_dev_close().

Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver")

Reported-by: Sunil Pai G <sunil.pai.g at intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
Reviewed-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Sunil Pai G <sunil.pai.g at intel.com>
Acked-by: Radu Nicolau <radu.nicolau at intel.com>
---
 drivers/raw/ioat/ioat_rawdev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c
index af8414b34c..a9b762330a 100644
--- a/drivers/raw/ioat/ioat_rawdev.c
+++ b/drivers/raw/ioat/ioat_rawdev.c
@@ -198,6 +198,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids)
 	return 0;
 }
 
+static int
+ioat_dev_close(struct rte_rawdev *dev __rte_unused)
+{
+	return 0;
+}
+
 extern int ioat_rawdev_test(uint16_t dev_id);
 
 static int
@@ -207,6 +213,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev)
 			.dev_configure = ioat_dev_configure,
 			.dev_start = ioat_dev_start,
 			.dev_stop = ioat_dev_stop,
+			.dev_close = ioat_dev_close,
 			.dev_info_get = ioat_dev_info_get,
 			.xstats_get = ioat_xstats_get,
 			.xstats_get_names = ioat_xstats_get_names,
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:15.386270719 +0000
+++ 0117-raw-ioat-fix-missing-close-function.patch	2020-10-28 10:35:11.672832496 +0000
@@ -1,8 +1,10 @@
-From 8c6cedee761c7abd8c3d451bffa7c70747ab7629 Mon Sep 17 00:00:00 2001
+From b0e37c91df43873f22c843875accceb1e11fa83f Mon Sep 17 00:00:00 2001
 From: Kevin Laatz <kevin.laatz at intel.com>
 Date: Thu, 8 Oct 2020 10:51:10 +0100
 Subject: [PATCH] raw/ioat: fix missing close function
 
+[ upstream commit 8c6cedee761c7abd8c3d451bffa7c70747ab7629 ]
+
 When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a
 dev_close function for the device causing a segmentation fault when no
 close() function is implemented for a driver.
@@ -10,7 +12,6 @@
 This patch resolves the issue by adding a stub function ioat_dev_close().
 
 Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver")
-Cc: stable at dpdk.org
 
 Reported-by: Sunil Pai G <sunil.pai.g at intel.com>
 Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
@@ -22,10 +23,10 @@
  1 file changed, 7 insertions(+)
 
 diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c
-index 7f1a154360..0732b059fe 100644
+index af8414b34c..a9b762330a 100644
 --- a/drivers/raw/ioat/ioat_rawdev.c
 +++ b/drivers/raw/ioat/ioat_rawdev.c
-@@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids)
+@@ -198,6 +198,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids)
  	return 0;
  }
  
@@ -38,7 +39,7 @@
  extern int ioat_rawdev_test(uint16_t dev_id);
  
  static int
-@@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev)
+@@ -207,6 +213,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev)
  			.dev_configure = ioat_dev_configure,
  			.dev_start = ioat_dev_start,
  			.dev_stop = ioat_dev_stop,


More information about the stable mailing list