[dpdk-stable] patch 'test/crypto: fix stats test' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 1efe9f0924ec1b1000df11834f974fe2a5c14db9 Mon Sep 17 00:00:00 2001
From: Ruifeng Wang <ruifeng.wang at arm.com>
Date: Mon, 31 Aug 2020 16:51:43 +0800
Subject: [PATCH] test/crypto: fix stats test

[ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ]

ut_setup / ut_teardown are invoked for each test case by test framework.
The call inside test_stats is unnecessary and even incorrect.
This caused double free of objects such as crypto operation structure.
Trapped the issue when RTE_LIBRTE_MEMPOOL_DEBUG was enabled.
Fix issue by removing ut_setup / ut_teardown from test case implementation.

Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")

Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
Tested-by: Adam Dybkowski <adamx.dybkowski at intel.com>
---
 app/test/test_cryptodev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 75d35c6582..a852040ec2 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -9425,9 +9425,7 @@ test_stats(void)
 		"rte_cryptodev_stats_get invalid Param failed");
 
 	/* Test expected values */
-	ut_setup();
 	test_AES_CBC_HMAC_SHA1_encrypt_digest();
-	ut_teardown();
 	TEST_ASSERT_SUCCESS(rte_cryptodev_stats_get(ts_params->valid_devs[0],
 			&stats),
 		"rte_cryptodev_stats_get failed");
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:16.301208099 +0000
+++ 0147-test-crypto-fix-stats-test.patch	2020-10-28 10:35:11.740833497 +0000
@@ -1,8 +1,10 @@
-From b450503612eebc59de96aa3f20ec5ea0e3ceb400 Mon Sep 17 00:00:00 2001
+From 1efe9f0924ec1b1000df11834f974fe2a5c14db9 Mon Sep 17 00:00:00 2001
 From: Ruifeng Wang <ruifeng.wang at arm.com>
 Date: Mon, 31 Aug 2020 16:51:43 +0800
 Subject: [PATCH] test/crypto: fix stats test
 
+[ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ]
+
 ut_setup / ut_teardown are invoked for each test case by test framework.
 The call inside test_stats is unnecessary and even incorrect.
 This caused double free of objects such as crypto operation structure.
@@ -10,7 +12,6 @@
 Fix issue by removing ut_setup / ut_teardown from test case implementation.
 
 Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
 Tested-by: Adam Dybkowski <adamx.dybkowski at intel.com>
@@ -19,10 +20,10 @@
  1 file changed, 2 deletions(-)
 
 diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
-index 704aa7c414..d702cb91a3 100644
+index 75d35c6582..a852040ec2 100644
 --- a/app/test/test_cryptodev.c
 +++ b/app/test/test_cryptodev.c
-@@ -9326,9 +9326,7 @@ test_stats(void)
+@@ -9425,9 +9425,7 @@ test_stats(void)
  		"rte_cryptodev_stats_get invalid Param failed");
  
  	/* Test expected values */