[dpdk-stable] patch 'cryptodev: fix parameter parsing' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 1d8fa909f9b5ea6eba8da1dcba3de63e39b2c6c5 Mon Sep 17 00:00:00 2001
From: Haggai Eran <haggaie at nvidia.com>
Date: Thu, 8 Oct 2020 22:42:14 +0300
Subject: [PATCH] cryptodev: fix parameter parsing

[ upstream commit 784fb396f72d98070f3afaf309a7addb4c0d8da1 ]

The rte_cryptodev_pmd_parse_input_args function crashes with a
segmentation fault when passing a non-empty argument string.

The function passes cryptodev_pmd_valid_params to rte_kvargs_parse,
which accepts a NULL-terminated list of valid keys, yet
cryptodev_pmd_valid_params does not end with NULL. The patch adds the
missing NULL pointer.

Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")

Signed-off-by: Haggai Eran <haggaie at nvidia.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
 lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h
index fba14f2fa0..c4935b3307 100644
--- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
+++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
@@ -41,7 +41,8 @@ extern "C" {
 static const char * const cryptodev_pmd_valid_params[] = {
 	RTE_CRYPTODEV_PMD_NAME_ARG,
 	RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG,
-	RTE_CRYPTODEV_PMD_SOCKET_ID_ARG
+	RTE_CRYPTODEV_PMD_SOCKET_ID_ARG,
+	NULL
 };
 
 /**
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:16.368510271 +0000
+++ 0149-cryptodev-fix-parameter-parsing.patch	2020-10-28 10:35:11.740833497 +0000
@@ -1,8 +1,10 @@
-From 784fb396f72d98070f3afaf309a7addb4c0d8da1 Mon Sep 17 00:00:00 2001
+From 1d8fa909f9b5ea6eba8da1dcba3de63e39b2c6c5 Mon Sep 17 00:00:00 2001
 From: Haggai Eran <haggaie at nvidia.com>
 Date: Thu, 8 Oct 2020 22:42:14 +0300
 Subject: [PATCH] cryptodev: fix parameter parsing
 
+[ upstream commit 784fb396f72d98070f3afaf309a7addb4c0d8da1 ]
+
 The rte_cryptodev_pmd_parse_input_args function crashes with a
 segmentation fault when passing a non-empty argument string.
 
@@ -12,7 +14,6 @@
 missing NULL pointer.
 
 Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
-Cc: stable at dpdk.org
 
 Signed-off-by: Haggai Eran <haggaie at nvidia.com>
 Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
@@ -21,7 +22,7 @@
  1 file changed, 2 insertions(+), 1 deletion(-)
 
 diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h
-index 81975d72b4..1367222f73 100644
+index fba14f2fa0..c4935b3307 100644
 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
 +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
 @@ -41,7 +41,8 @@ extern "C" {