No subject

[Christian Ehrhardt]

On Thu, Dec 2, 2021 at 3:12 PM David Marchand <david.marchand at redhat.com> wrote:
>
> Hello,
>
> On Tue, Nov 30, 2021 at 5:56 PM <christian.ehrhardt at canonical.com> wrote:
> > Applying but breaking the build:
> >
> > 86e361cdeb  David Marchand   test/cmdline: fix memory leak
>
> It is not marked for backport: it fixes 6ad06203a587 ("cmdline: free
> on exit") that introduced an API change (making it itself not
> backportable).
> Why did you consider this patch?

Hi David,
the tooling selects initially any patch that fulfils either condition
1. marked for stable at dpdk
2. has a Fixes: entry
3. has "fix" in the subject

We (the stable maintainers) then do some filtering for patches that we
find non-needed or ABI affecting.
This time for example I cut down an initial 516 to 274.

But we might miss one and hence the requests to the Authors (as they
know best) and the further testing from there.


> > ---
> >
> > Not Applying
> >
> > fe629897de  David Marchand   app/testpmd: remove double dependency on bitrate lib
>
> Looking at 19.11 branch, this backport is not needed as Luca already
> dropped double reference in a 19.11 only patch:
> a7a21ffad191 ("Revert "app/testpmd: fix name of bitrate library in
> meson build"")

Ok

> > b72099be7f  David Marchand   net/virtio-user: fix init when using existing tap
>
> This was not supported before, and it is not marked for backport, on purpose.
>
>
> > 4a985f4e84  David Marchand   test/service: fix race in attr check
>
> It fixes another fix which is not in 19.11:
> 52bb6be259ff ("test/service: fix race condition on stopping lcore")
>
> You can skip it.

Ok
Thanks for your expertise on your changes!


> Thanks.
>
> --
> David Marchand
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd