19.11.11 patches review and test

[Richardson, Bruce]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, December 17, 2021 2:56 PM
> To: 'Christian Ehrhardt' <christian.ehrhardt at canonical.com>
> Cc: stable at dpdk.org
> Subject: RE: 19.11.11 patches review and test
> 
> Hi Christian,
> 
> just tried compiling latest 19.11 branch in dpdk-stable tree (which is
> your 19.11.11-rc1 commit) on FreeBSD 13, and see the following error:
> 
> [11/1452] Compiling C object
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> FAILED: lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
> cc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config -
> Ilib/librte_eal/common/include -I../lib/librte_eal/common/include -
> I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common -
> I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -
> I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal -
> I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -fcolor-
> diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -
> include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-
> nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -
> Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -
> Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -
> Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC -
> march=native -DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -MF
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o.d -o
> lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o -c
> ../lib/librte_eal/common/eal_common_options.c
> ../lib/librte_eal/common/eal_common_options.c:1499:2: error: implicit
> declaration of function 'CPU_NAND' is invalid in C99 [-Werror,-Wimplicit-
> function-declaration]
> 
> It looks to me that commit 9ed3385f "eal/freebsd: update CPU macro for
> FreeBSD 13" needs to be applied to 19.11 branch.
> 
> Other errors on FreeBSD 13 have been reported too, I'm looking into those.

Looks like 03bff90ccfd6 ("contigmem: update for FreeBSD 13") could do with being cherry-picked too for 19.11.

With that done (2 patches cherry-picked, and one additional patch applied that I have just sent), I get a clean build on FBSD 13.

Regards,
/Bruce