[dpdk-stable] patch 'eal/windows: fix vfprintf warning with clang' has been queued to stable release 20.11.1
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 5 12:14:50 CET 2021
Hi,
FYI, your patch has been queued to stable release 20.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/6b2eccd104c1b3a8bba51bf10d40e203ef21baae
Thanks.
Luca Boccassi
---
>From 6b2eccd104c1b3a8bba51bf10d40e203ef21baae Mon Sep 17 00:00:00 2001
From: Nick Connolly <nick.connolly at mayadata.io>
Date: Sun, 29 Nov 2020 13:00:47 +0000
Subject: [PATCH] eal/windows: fix vfprintf warning with clang
[ upstream commit 498ec3c6da6da0a8c9e6ad7ddd087e10faa77eb0 ]
When building with clang (11.0,--buildtype=debug), eal_lcore.c
produces a -Wformat-nonliteral warning from the vfprintf call
in log_early.
Add __rte_format_printf annotation.
Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection")
Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
Signed-off-by: Nick Connolly <nick.connolly at mayadata.io>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
Acked-by: Pallavi Kadam <pallavi.kadam at intel.com>
---
lib/librte_eal/windows/eal_lcore.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c
index d5ff721e03..a85149be95 100644
--- a/lib/librte_eal/windows/eal_lcore.c
+++ b/lib/librte_eal/windows/eal_lcore.c
@@ -38,6 +38,7 @@ static struct cpu_map cpu_map = { 0 };
/* eal_create_cpu_map() is called before logging is initialized */
static void
+__rte_format_printf(1, 2)
log_early(const char *format, ...)
{
va_list va;
--
2.29.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-02-05 11:18:29.529448698 +0000
+++ 0004-eal-windows-fix-vfprintf-warning-with-clang.patch 2021-02-05 11:18:28.582686848 +0000
@@ -1 +1 @@
-From 498ec3c6da6da0a8c9e6ad7ddd087e10faa77eb0 Mon Sep 17 00:00:00 2001
+From 6b2eccd104c1b3a8bba51bf10d40e203ef21baae Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 498ec3c6da6da0a8c9e6ad7ddd087e10faa77eb0 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list