[dpdk-stable] RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE not present in 19.11.x series

Christian Ehrhardt christian.ehrhardt at canonical.com
Tue Jun 1 10:25:29 CEST 2021


Hi,
this was targeted at the stable releases:

commit 1bdcca8006e4c690d017531f7fc6c31b19ad8d1d
Author: Chengwen Feng <fengchengwen at huawei.com>
Date:   Sat Apr 17 17:54:58 2021 +0800

    net/hns3: fix flow director lock


But it introduced

../drivers/net/hns3/hns3_flow.c: In function ‘hns3_flow_init’:
../drivers/net/hns3/hns3_flow.c:1168:27: error:
‘RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE’ undeclared (first use in this
function)
 1168 |   dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/hns3/hns3_flow.c:1168:27: note: each undeclared
identifier is reported only once for each function it appears in


The reason is that this was introduced in 20.11

commit 80d1a9aff7f6088ea97d78e36de3f9edae018f1c
Author: Suanming Mou <suanmingm at nvidia.com>
Date:   Thu Oct 15 09:07:47 2020 +0800

    ethdev: make flow API thread safe

I'm unsure about the potential implications to e.g. just strip declaring
RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE from your patch so if you'd want to have
that one applied ti 19.11.x I'd ask you to have a more detailed look
and consider providing a backport or letting me know that this patch isn't
needed for 19.11.x

Thanks in advance,
Christian

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd


More information about the stable mailing list