[dpdk-stable] patch 'net/hns3: fix link status when port is stopped' has been queued to stable release 20.11.2

[Xueming Li]

Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/3502d412a050f848da6c946f605a5362fe48decc

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 3502d412a050f848da6c946f605a5362fe48decc Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Sun, 25 Apr 2021 20:06:28 +0800
Subject: [PATCH] net/hns3: fix link status when port is stopped
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 64308555d5bf8d7da8c3bde7d9c32550ac9c4382 ]

When port is stopped, link down should be reported to user. For HNS3
PF driver, link status comes from link status of hardware. If the port
supports NCSI feature, hardware MAC will not be disabled. At this case,
even if the port is stopped, the link status is still Up. So driver
should set link down when the port is stopped.

Fixes: 59fad0f32135 ("net/hns3: support link update operation")

Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/net/hns3/hns3_ethdev.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 8e4692385d..01ff8de7f7 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2709,6 +2709,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
 	struct rte_eth_link new_link;
 	int ret;
 
+	/* When port is stopped, report link down. */
+	if (eth_dev->data->dev_started == 0) {
+		new_link.link_autoneg = mac->link_autoneg;
+		new_link.link_duplex = mac->link_duplex;
+		new_link.link_speed = ETH_SPEED_NUM_NONE;
+		new_link.link_status = ETH_LINK_DOWN;
+		goto out;
+	}
+
 	ret = hns3_update_port_link_info(eth_dev);
 	if (ret) {
 		mac->link_status = ETH_LINK_DOWN;
@@ -2718,6 +2727,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
 	memset(&new_link, 0, sizeof(new_link));
 	hns3_setup_linkstatus(eth_dev, &new_link);
 
+out:
 	return rte_eth_linkstatus_set(eth_dev, &new_link);
 }
 
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:57.814085000 +0800
+++ 0045-net-hns3-fix-link-status-when-port-is-stopped.patch	2021-06-12 06:53:56.220000000 +0800
@@ -1 +1 @@
-From 64308555d5bf8d7da8c3bde7d9c32550ac9c4382 Mon Sep 17 00:00:00 2001
+From 3502d412a050f848da6c946f605a5362fe48decc Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 64308555d5bf8d7da8c3bde7d9c32550ac9c4382 ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
@@ -22 +24 @@
-index e3f1b7c3ad..63ae555c9d 100644
+index 8e4692385d..01ff8de7f7 100644
@@ -25 +27 @@
-@@ -2897,6 +2897,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
+@@ -2709,6 +2709,15 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,
@@ -38,4 +40,4 @@
- 	do {
- 		ret = hns3_update_port_link_info(eth_dev);
- 		if (ret) {
-@@ -2914,6 +2923,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete)
+ 	ret = hns3_update_port_link_info(eth_dev);
+ 	if (ret) {
+ 		mac->link_status = ETH_LINK_DOWN;
+@@ -2718,6 +2727,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,