[dpdk-stable] patch 'net/kni: warn on stop failure' has been queued to stable release 20.11.2

[Xueming Li]

Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/9874e06dc5788832ba924480918fbced7dbd17bb

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 9874e06dc5788832ba924480918fbced7dbd17bb Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Tue, 27 Apr 2021 10:08:45 +0800
Subject: [PATCH] net/kni: warn on stop failure
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit b752fb4d626c4a0f4a90f04df3684cb5318c376f ]

Return value of function 'eth_kni_dev_stop' passed to 'ret' is
rewritten later, and this is unreasonable.

This patch fixes it.

Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int")

Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/kni/rte_eth_kni.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index aae6dcb54e..5d8fb1451a 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -211,6 +211,9 @@ eth_kni_close(struct rte_eth_dev *eth_dev)
 		return 0;
 
 	ret = eth_kni_dev_stop(eth_dev);
+	if (ret)
+		PMD_LOG(WARNING, "Not able to stop kni for %s",
+			eth_dev->data->name);
 
 	/* mac_addrs must not be freed alone because part of dev_private */
 	eth_dev->data->mac_addrs = NULL;
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:57.930095300 +0800
+++ 0049-net-kni-warn-on-stop-failure.patch	2021-06-12 06:53:56.240000000 +0800
@@ -1 +1 @@
-From b752fb4d626c4a0f4a90f04df3684cb5318c376f Mon Sep 17 00:00:00 2001
+From 9874e06dc5788832ba924480918fbced7dbd17bb Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit b752fb4d626c4a0f4a90f04df3684cb5318c376f ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -21 +23 @@
-index 4d2a42ddab..51daf08591 100644
+index aae6dcb54e..5d8fb1451a 100644