[dpdk-stable] patch 'net/mlx5: fix secondary process initialization ordering' has been queued to stable release 20.11.2
Xueming Li
xuemingl at nvidia.com
Sat Jun 12 01:03:56 CEST 2021
Hi,
FYI, your patch has been queued to stable release 20.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/cb97d5942878f53de74075e704f62e6119d4795e
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From cb97d5942878f53de74075e704f62e6119d4795e Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Mon, 10 May 2021 20:06:03 +0800
Subject: [PATCH] net/mlx5: fix secondary process initialization ordering
Cc: Luca Boccassi <bluca at debian.org>
[ upstream commit 69b44d6bce1c9990e522a08f693d5f9f2e2e5067 ]
The memory barrier is used to ensure that the response is returned
only after the Tx/Rx function is set, it should place after the Rx/Tx
function is set.
Fixes: 2aac5b5d119f ("net/mlx5: sync stop/start with secondary process")
Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
drivers/net/mlx5/linux/mlx5_mp_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c b/drivers/net/mlx5/linux/mlx5_mp_os.c
index 95372e2084..8567e43471 100644
--- a/drivers/net/mlx5/linux/mlx5_mp_os.c
+++ b/drivers/net/mlx5/linux/mlx5_mp_os.c
@@ -130,7 +130,6 @@ struct rte_mp_msg mp_res;
switch (param->type) {
case MLX5_MP_REQ_START_RXTX:
DRV_LOG(INFO, "port %u starting datapath", dev->data->port_id);
- rte_mb();
dev->rx_pkt_burst = mlx5_select_rx_function(dev);
dev->tx_pkt_burst = mlx5_select_tx_function(dev);
ppriv = (struct mlx5_proc_priv *)dev->process_private;
@@ -147,6 +146,7 @@ struct rte_mp_msg mp_res;
return -rte_errno;
}
}
+ rte_mb();
mp_init_msg(&priv->mp_id, &mp_res, param->type);
res->result = 0;
ret = rte_mp_reply(&mp_res, peer);
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-06-12 06:54:00.202393700 +0800
+++ 0142-net-mlx5-fix-secondary-process-initialization-orderi.patch 2021-06-12 06:53:56.590000000 +0800
@@ -1 +1 @@
-From 69b44d6bce1c9990e522a08f693d5f9f2e2e5067 Mon Sep 17 00:00:00 2001
+From cb97d5942878f53de74075e704f62e6119d4795e Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 69b44d6bce1c9990e522a08f693d5f9f2e2e5067 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index ca529b6007..3a4aa766f8 100644
+index 95372e2084..8567e43471 100644
@@ -23 +25 @@
-@@ -132,7 +132,6 @@ struct rte_mp_msg mp_res;
+@@ -130,7 +130,6 @@ struct rte_mp_msg mp_res;
@@ -31 +33 @@
-@@ -149,6 +148,7 @@ struct rte_mp_msg mp_res;
+@@ -147,6 +146,7 @@ struct rte_mp_msg mp_res;
More information about the stable
mailing list