[dpdk-stable] patch 'examples/skeleton: fix NUMA check of port and core' has been queued to stable release 20.11.2
Xueming Li
xuemingl at nvidia.com
Sat Jun 12 01:04:04 CEST 2021
Hi,
FYI, your patch has been queued to stable release 20.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/acf64e968541c95f31185d09d537639b4e647ff9
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From acf64e968541c95f31185d09d537639b4e647ff9 Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Thu, 29 Apr 2021 08:50:48 +0800
Subject: [PATCH] examples/skeleton: fix NUMA check of port and core
Cc: Luca Boccassi <bluca at debian.org>
[ upstream commit 5ffa60cd77c76855690d06cb900d6670f29de9a6 ]
According to the comments and logging, the author just hope user to use
the core and device which are in the same numa node for optimal
performance. If not, A warning gives out.
This patch fixes the check for a device on the node 0.
Fixes: 7107e471a6c7 ("examples/skeleton: very simple code for packet forwarding")
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
examples/skeleton/basicfwd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basicfwd.c
index a31b2882ae..43b9d17a3c 100644
--- a/examples/skeleton/basicfwd.c
+++ b/examples/skeleton/basicfwd.c
@@ -122,7 +122,7 @@ lcore_main(void)
* for best performance.
*/
RTE_ETH_FOREACH_DEV(port)
- if (rte_eth_dev_socket_id(port) > 0 &&
+ if (rte_eth_dev_socket_id(port) >= 0 &&
rte_eth_dev_socket_id(port) !=
(int)rte_socket_id())
printf("WARNING, port %u is on remote NUMA node to "
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-06-12 06:54:00.381594200 +0800
+++ 0150-examples-skeleton-fix-NUMA-check-of-port-and-core.patch 2021-06-12 06:53:56.610000000 +0800
@@ -1 +1 @@
-From 5ffa60cd77c76855690d06cb900d6670f29de9a6 Mon Sep 17 00:00:00 2001
+From acf64e968541c95f31185d09d537639b4e647ff9 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 5ffa60cd77c76855690d06cb900d6670f29de9a6 ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list