[dpdk-stable] [PATCH v3 1/2] examples/l2fwd: fix long option parsing
SunChengLian
sunchenglian at loongson.cn
Tue Jun 22 04:47:05 CEST 2021
For l2fwd, --no-mac-updating and --mac-updating are treated as invalid
arguments.Rework long options parsing to let --no-mac-updating and
--mac-updating options work well.
Fixes: fa19eb20d212 ("examples/l2fwd: add forwarding port mapping option")
Cc: vattunuru at marvell.com
Cc: stable at dpdk.org
Signed-off-by: SunChengLian <sunchenglian at loongson.cn>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
examples/l2fwd/main.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
index ffb67bb901..23e5e46761 100644
--- a/examples/l2fwd/main.c
+++ b/examples/l2fwd/main.c
@@ -434,13 +434,16 @@ enum {
/* first long only option value must be >= 256, so that we won't
* conflict with short options */
- CMD_LINE_OPT_MIN_NUM = 256,
+ CMD_LINE_OPT_MAC_UPDATING_NUM = 256,
+ CMD_LINE_OPT_NO_MAC_UPDATING_NUM,
CMD_LINE_OPT_PORTMAP_NUM,
};
static const struct option lgopts[] = {
- { CMD_LINE_OPT_MAC_UPDATING, no_argument, &mac_updating, 1},
- { CMD_LINE_OPT_NO_MAC_UPDATING, no_argument, &mac_updating, 0},
+ { CMD_LINE_OPT_MAC_UPDATING, no_argument, 0,
+ CMD_LINE_OPT_MAC_UPDATING_NUM},
+ { CMD_LINE_OPT_NO_MAC_UPDATING, no_argument, 0,
+ CMD_LINE_OPT_NO_MAC_UPDATING_NUM},
{ CMD_LINE_OPT_PORTMAP_CONFIG, 1, 0, CMD_LINE_OPT_PORTMAP_NUM},
{NULL, 0, 0, 0}
};
@@ -502,6 +505,14 @@ l2fwd_parse_args(int argc, char **argv)
}
break;
+ case CMD_LINE_OPT_MAC_UPDATING_NUM:
+ mac_updating = 1;
+ break;
+
+ case CMD_LINE_OPT_NO_MAC_UPDATING_NUM:
+ mac_updating = 0;
+ break;
+
default:
l2fwd_usage(prgname);
return -1;
--
2.25.1
More information about the stable
mailing list