[dpdk-stable] patch 'test/cmdline: fix memory leak' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Wed Nov 10 07:31:28 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/e8a4c7a8d07eb7ec0a3e543ce99c8a1d09b8ac2a

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From e8a4c7a8d07eb7ec0a3e543ce99c8a1d09b8ac2a Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Fri, 29 Oct 2021 13:23:15 +0200
Subject: [PATCH] test/cmdline: fix memory leak
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 86e361cdeb495c70a154f25cd47fd6581c9aff89 ]

Previous change wrongly removed cmdline_free().

Fixes: 6ad06203a587 ("cmdline: free on exit")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Olivier Matz <olivier.matz at 6wind.com>
---
 app/test/test_cmdline_lib.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c
index 6bcfa6511e..94c9ce04b4 100644
--- a/app/test/test_cmdline_lib.c
+++ b/app/test/test_cmdline_lib.c
@@ -170,6 +170,8 @@ test_cmdline_socket_fns(void)
 		printf("Error: failed to open /dev/null for reading!");
 		return -1;
 	}
+	cmdline_free(cl);
+	cl = NULL;
 
 	/* void functions */
 	cmdline_stdin_exit(NULL);
-- 
2.33.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-10 14:17:10.940494564 +0800
+++ 0204-test-cmdline-fix-memory-leak.patch	2021-11-10 14:17:02.014078251 +0800
@@ -1 +1 @@
-From 86e361cdeb495c70a154f25cd47fd6581c9aff89 Mon Sep 17 00:00:00 2001
+From e8a4c7a8d07eb7ec0a3e543ce99c8a1d09b8ac2a Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 86e361cdeb495c70a154f25cd47fd6581c9aff89 ]
@@ -17 +20 @@
-index f238094b07..f50ccdb599 100644
+index 6bcfa6511e..94c9ce04b4 100644
@@ -20 +23 @@
-@@ -176,6 +176,8 @@ test_cmdline_socket_fns(void)
+@@ -170,6 +170,8 @@ test_cmdline_socket_fns(void)


More information about the stable mailing list