[dpdk-stable] patch 'net/mlx5: fix RSS RETA update' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Wed Nov 10 07:31:40 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/5e6ca029a2360b7b20f2b28df64a5bf8046f779e

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 5e6ca029a2360b7b20f2b28df64a5bf8046f779e Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Wed, 27 Oct 2021 16:22:12 +0200
Subject: [PATCH] net/mlx5: fix RSS RETA update
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 5aeb7fab59fef7b9cb01ec58ef32d1068923b6d3 ]

This patch fixes RETA updating for entries above 64.
Without that, these entries are never updated as
calculated mask value will always be 0.

Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 drivers/net/mlx5/mlx5_rss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c
index 845cebe2e8..0aa3b4ed98 100644
--- a/drivers/net/mlx5/mlx5_rss.c
+++ b/drivers/net/mlx5/mlx5_rss.c
@@ -210,7 +210,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
 	for (idx = 0, i = 0; (i != reta_size); ++i) {
 		idx = i / RTE_RETA_GROUP_SIZE;
 		pos = i % RTE_RETA_GROUP_SIZE;
-		if (((reta_conf[idx].mask >> i) & 0x1) == 0)
+		if (((reta_conf[idx].mask >> pos) & 0x1) == 0)
 			continue;
 		MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n);
 		(*priv->reta_idx)[i] = reta_conf[idx].reta[pos];
-- 
2.33.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-10 14:17:11.443627602 +0800
+++ 0216-net-mlx5-fix-RSS-RETA-update.patch	2021-11-10 14:17:02.027411476 +0800
@@ -1 +1 @@
-From 5aeb7fab59fef7b9cb01ec58ef32d1068923b6d3 Mon Sep 17 00:00:00 2001
+From 5e6ca029a2360b7b20f2b28df64a5bf8046f779e Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 5aeb7fab59fef7b9cb01ec58ef32d1068923b6d3 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index a4f690039e..a04e22398d 100644
+index 845cebe2e8..0aa3b4ed98 100644
@@ -23 +25 @@
-@@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
+@@ -210,7 +210,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
@@ -25,2 +27,2 @@
- 		idx = i / RTE_ETH_RETA_GROUP_SIZE;
- 		pos = i % RTE_ETH_RETA_GROUP_SIZE;
+ 		idx = i / RTE_RETA_GROUP_SIZE;
+ 		pos = i % RTE_RETA_GROUP_SIZE;


More information about the stable mailing list