[dpdk-stable] patch 'common/mlx5: fix UAR allocation diagnostics messages' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Wed Nov 10 07:32:07 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/b6d5c0004bb530eb2ae3ee0a79520045a82ef2c5

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From b6d5c0004bb530eb2ae3ee0a79520045a82ef2c5 Mon Sep 17 00:00:00 2001
From: Michael Baum <michaelba at nvidia.com>
Date: Wed, 3 Nov 2021 20:35:10 +0200
Subject: [PATCH] common/mlx5: fix UAR allocation diagnostics messages
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 3f0e54fe00de7aec060afd50bfb288a8a43d0689 ]

Depending on kernel capabilities and rdma-core version the mapping of
UAR (User Access Region) of desired memory caching type (non-cached or
write combining) might fail. The PMD implements the flexible strategy
of UAR mapping, alternating the type of caching to succeed.

During this process the failure diagnostics messages are emitted.
These messages are merely diagnostics ones and the logging level should
be adjusted to DEBUG.

Fixes: 9cc0e99c81ab0 ("common/mlx5: share UAR allocation routine")

Signed-off-by: Michael Baum <michaelba at nvidia.com>
Reviewed-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
 drivers/common/mlx5/mlx5_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c
index 0db9882c43..c348caaedf 100644
--- a/drivers/common/mlx5/mlx5_common.c
+++ b/drivers/common/mlx5/mlx5_common.c
@@ -289,7 +289,7 @@ mlx5_devx_alloc_uar(void *ctx, int mapping)
 			 * If Verbs/kernel does not support "Non-Cached"
 			 * try the "Write-Combining".
 			 */
-			DRV_LOG(WARNING, "Failed to allocate DevX UAR (NC)");
+			DRV_LOG(DEBUG, "Failed to allocate DevX UAR (NC)");
 			uar_mapping = MLX5DV_UAR_ALLOC_TYPE_BF;
 			uar = mlx5_glue->devx_alloc_uar(ctx, uar_mapping);
 		}
@@ -307,7 +307,7 @@ mlx5_devx_alloc_uar(void *ctx, int mapping)
 		 * IB device context, on context closure all UARs
 		 * will be freed, should be no memory/object leakage.
 		 */
-		DRV_LOG(WARNING, "Retrying to allocate DevX UAR");
+		DRV_LOG(DEBUG, "Retrying to allocate DevX UAR");
 		uar = NULL;
 	}
 	/* Check whether we finally succeeded with valid UAR allocation. */
-- 
2.33.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-10 14:17:12.584538701 +0800
+++ 0243-common-mlx5-fix-UAR-allocation-diagnostics-messages.patch	2021-11-10 14:17:02.084077679 +0800
@@ -1 +1 @@
-From 3f0e54fe00de7aec060afd50bfb288a8a43d0689 Mon Sep 17 00:00:00 2001
+From b6d5c0004bb530eb2ae3ee0a79520045a82ef2c5 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 3f0e54fe00de7aec060afd50bfb288a8a43d0689 ]
@@ -16 +18,0 @@
-Cc: stable at dpdk.org
@@ -26 +28 @@
-index e8603c7ea9..e3497c40eb 100644
+index 0db9882c43..c348caaedf 100644
@@ -29 +31 @@
-@@ -977,7 +977,7 @@ mlx5_devx_alloc_uar(void *ctx, int mapping)
+@@ -289,7 +289,7 @@ mlx5_devx_alloc_uar(void *ctx, int mapping)
@@ -38 +40 @@
-@@ -995,7 +995,7 @@ mlx5_devx_alloc_uar(void *ctx, int mapping)
+@@ -307,7 +307,7 @@ mlx5_devx_alloc_uar(void *ctx, int mapping)


More information about the stable mailing list