patch 'net/bnxt: fix autoneg on PAM4 links' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Sun Nov 28 15:54:08 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/30/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/932ade3bdcaceccd3704b34d13ed7ae1cebe2734

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 932ade3bdcaceccd3704b34d13ed7ae1cebe2734 Mon Sep 17 00:00:00 2001
From: Somnath Kotur <somnath.kotur at broadcom.com>
Date: Thu, 18 Nov 2021 09:34:39 +0530
Subject: [PATCH] net/bnxt: fix autoneg on PAM4 links
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit e806385c6deaba31b7f81931c44e7867a2ebdfb7 ]

If autonegotiation was enabled, driver was not passing the
'auto_pam4_link_speeds' obtained during init and stored in bp->link_info
to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting
being passed to the HW during PHY configuration. This in turn, would
result in invalid settings being retrieved and configured in subsequent
application loads resulting in launch failures.

Bugzilla ID: 791
Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link")

Reported-by: Charles Brett <cfb at hpe.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur at broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index b78e099a5e..71ddc6f55d 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3148,6 +3148,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)
 		link_req.auto_link_speed_mask =
 			bnxt_parse_eth_link_speed_mask(bp,
 						       dev_conf->link_speeds);
+		link_req.auto_pam4_link_speeds =
+			bp->link_info->auto_pam4_link_speeds;
 	} else {
 		if (bp->link_info->phy_type ==
 		    HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET ||
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-28 22:41:06.514543200 +0800
+++ 0064-net-bnxt-fix-autoneg-on-PAM4-links.patch	2021-11-28 22:41:03.406872744 +0800
@@ -1 +1 @@
-From e806385c6deaba31b7f81931c44e7867a2ebdfb7 Mon Sep 17 00:00:00 2001
+From 932ade3bdcaceccd3704b34d13ed7ae1cebe2734 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit e806385c6deaba31b7f81931c44e7867a2ebdfb7 ]
@@ -15 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +27 @@
-index 6de3b92c40..7f51c61097 100644
+index b78e099a5e..71ddc6f55d 100644
@@ -28 +30 @@
-@@ -3247,6 +3247,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)
+@@ -3148,6 +3148,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)


More information about the stable mailing list