patch 'eal/ppc: ignore GCC 10 stringop-overflow warnings' has been queued to stable release 19.11.11
christian.ehrhardt at canonical.com
christian.ehrhardt at canonical.com
Tue Nov 30 17:33:34 CET 2021
Hi,
FYI, your patch has been queued to stable release 19.11.11
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before December 10th 2021. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/4990929c60fec6666e4b5891d01f5b555e7a443d
Thanks.
Christian Ehrhardt <christian.ehrhardt at canonical.com>
---
>From 4990929c60fec6666e4b5891d01f5b555e7a443d Mon Sep 17 00:00:00 2001
From: David Christensen <drc at linux.vnet.ibm.com>
Date: Thu, 2 Sep 2021 15:15:14 -0700
Subject: [PATCH] eal/ppc: ignore GCC 10 stringop-overflow warnings
[ upstream commit c13e6177394365d4db1595ea038bd9c3de04d32f ]
Suppress gcc warning "warning: writing 16 bytes into a region of
size 0" for users of the POWER rte_memcpy() function. Existing
rte_memcpy() code takes different code paths based on the actual
size of the move so the warning is already addressed. See also
commit b5b3ea803e47 ("eal/x86: ignore gcc 10 stringop-overflow warnings")
Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
---
.../common/include/arch/ppc_64/rte_memcpy.h | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
index e63a1211a8..10ed5159af 100644
--- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
@@ -1,6 +1,6 @@
/*
* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (C) IBM Corporation 2014.
+ * Copyright (C) IBM Corporation 2014,2021
*/
#ifndef _RTE_MEMCPY_PPC_64_H_
@@ -19,11 +19,16 @@ extern "C" {
#include "generic/rte_memcpy.h"
-#if (GCC_VERSION >= 90000 && GCC_VERSION < 90400)
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 90000)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Warray-bounds"
#endif
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 100000)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstringop-overflow"
+#endif
+
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
{
@@ -199,7 +204,11 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
return ret;
}
-#if (GCC_VERSION >= 90000 && GCC_VERSION < 90400)
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 100000)
+#pragma GCC diagnostic pop
+#endif
+
+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 90000)
#pragma GCC diagnostic pop
#endif
--
2.34.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-11-30 16:50:06.735658011 +0100
+++ 0010-eal-ppc-ignore-GCC-10-stringop-overflow-warnings.patch 2021-11-30 16:50:05.514871505 +0100
@@ -1 +1 @@
-From c13e6177394365d4db1595ea038bd9c3de04d32f Mon Sep 17 00:00:00 2001
+From 4990929c60fec6666e4b5891d01f5b555e7a443d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c13e6177394365d4db1595ea038bd9c3de04d32f ]
+
@@ -12,2 +13,0 @@
-Cc: stable at dpdk.org
-
@@ -16 +16 @@
- lib/eal/ppc/include/rte_memcpy.h | 15 ++++++++++++---
+ .../common/include/arch/ppc_64/rte_memcpy.h | 15 ++++++++++++---
@@ -19,4 +19,4 @@
-diff --git a/lib/eal/ppc/include/rte_memcpy.h b/lib/eal/ppc/include/rte_memcpy.h
-index c2a1f356d5..6f388c0234 100644
---- a/lib/eal/ppc/include/rte_memcpy.h
-+++ b/lib/eal/ppc/include/rte_memcpy.h
+diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
+index e63a1211a8..10ed5159af 100644
+--- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
++++ b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h
@@ -31 +31 @@
-@@ -18,11 +18,16 @@ extern "C" {
+@@ -19,11 +19,16 @@ extern "C" {
@@ -49 +49 @@
-@@ -198,7 +203,11 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
+@@ -199,7 +204,11 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
More information about the stable
mailing list