patch 'examples/fips_validation: remove unused allocation' has been queued to stable release 19.11.11
christian.ehrhardt at canonical.com
christian.ehrhardt at canonical.com
Tue Nov 30 17:34:24 CET 2021
Hi,
FYI, your patch has been queued to stable release 19.11.11
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before December 10th 2021. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/688244964296f60dbeb630c607cccfdab79b5b6a
Thanks.
Christian Ehrhardt <christian.ehrhardt at canonical.com>
---
>From 688244964296f60dbeb630c607cccfdab79b5b6a Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Thu, 12 Aug 2021 14:24:34 +0000
Subject: [PATCH] examples/fips_validation: remove unused allocation
[ upstream commit 25d392e1999b3d766f3a9f142372cc1220fa2c97 ]
The val.val pointer is allocated memory, however this memory is then
freed in get_writeback_data() without being used beforehand.
The pointer is then allocated memory again before use,
so the very first allocation is removed as it was unnecessary.
Fixes: f4797bae0050 ("examples/fips_validation: support plain SHA")
Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Fan Zhang <roy.fan.zhang at intel.com>
---
examples/fips_validation/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 2f8238886b..5a4a25cb61 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1373,7 +1373,6 @@ fips_mct_sha_test(void)
int ret;
uint32_t i, j;
- val.val = rte_malloc(NULL, (MAX_DIGEST_SIZE*SHA_MD_BLOCK), 0);
for (i = 0; i < SHA_MD_BLOCK; i++)
md[i].val = rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0);
--
2.34.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-11-30 16:50:09.493265796 +0100
+++ 0060-examples-fips_validation-remove-unused-allocation.patch 2021-11-30 16:50:05.726873060 +0100
@@ -1 +1 @@
-From 25d392e1999b3d766f3a9f142372cc1220fa2c97 Mon Sep 17 00:00:00 2001
+From 688244964296f60dbeb630c607cccfdab79b5b6a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 25d392e1999b3d766f3a9f142372cc1220fa2c97 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index a8daad1f48..c0e68b8848 100644
+index 2f8238886b..5a4a25cb61 100644
@@ -24 +25 @@
-@@ -1632,7 +1632,6 @@ fips_mct_sha_test(void)
+@@ -1373,7 +1373,6 @@ fips_mct_sha_test(void)
More information about the stable
mailing list