patch 'vfio: fix FreeBSD documentation' has been queued to stable release 19.11.11
christian.ehrhardt at canonical.com
christian.ehrhardt at canonical.com
Tue Nov 30 17:35:29 CET 2021
Hi,
FYI, your patch has been queued to stable release 19.11.11
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before December 10th 2021. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/4c105c785cf833e8b9214fef69564ec64e0bcc5c
Thanks.
Christian Ehrhardt <christian.ehrhardt at canonical.com>
---
>From 4c105c785cf833e8b9214fef69564ec64e0bcc5c Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Thu, 28 Oct 2021 14:15:18 +0000
Subject: [PATCH] vfio: fix FreeBSD documentation
[ upstream commit da6e4cdca1144e2cc6f9f495a34d3085e707b78a ]
On FreeBSD, `rte_vfio_is_enabled()` and `rte_vfio_noiommu_is_enabled()`
API calls will not return error, and will instead return 0. This is
intentional, because the caller of this API does not care whether VFIO
is supported at all, and will instead be interested in whether VFIO is
enabled or not. However, the doxygen comments for these functions state
that they will return an error on FreeBSD, which is incorrect.
Fix the doxygen comment to call out the fact that these
functions are only relevant on Linux, but remove the reference to
returning errors.
Fixes: 279b581c897d ("vfio: expose functions")
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Chenbo Xia <chenbo.xia at intel.com>
---
lib/librte_eal/common/include/rte_vfio.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_vfio.h b/lib/librte_eal/common/include/rte_vfio.h
index 2d90b36480..7bdb8932b2 100644
--- a/lib/librte_eal/common/include/rte_vfio.h
+++ b/lib/librte_eal/common/include/rte_vfio.h
@@ -150,8 +150,7 @@ int rte_vfio_enable(const char *modname);
/**
* Check whether a VFIO-related kmod is enabled.
*
- * This function is only relevant to linux and will return
- * an error on BSD.
+ * This function is only relevant to Linux.
*
* @param modname
* kernel module name.
@@ -165,8 +164,7 @@ int rte_vfio_is_enabled(const char *modname);
/**
* Whether VFIO NOIOMMU mode is enabled.
*
- * This function is only relevant to linux and will return
- * an error on BSD.
+ * This function is only relevant to Linux.
*
* @return
* 1 if true.
--
2.34.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-11-30 16:50:13.241752101 +0100
+++ 0125-vfio-fix-FreeBSD-documentation.patch 2021-11-30 16:50:05.958874763 +0100
@@ -1 +1 @@
-From da6e4cdca1144e2cc6f9f495a34d3085e707b78a Mon Sep 17 00:00:00 2001
+From 4c105c785cf833e8b9214fef69564ec64e0bcc5c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit da6e4cdca1144e2cc6f9f495a34d3085e707b78a ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
- lib/eal/include/rte_vfio.h | 6 ++----
+ lib/librte_eal/common/include/rte_vfio.h | 6 ++----
@@ -26 +27 @@
-diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h
+diff --git a/lib/librte_eal/common/include/rte_vfio.h b/lib/librte_eal/common/include/rte_vfio.h
@@ -28,2 +29,2 @@
---- a/lib/eal/include/rte_vfio.h
-+++ b/lib/eal/include/rte_vfio.h
+--- a/lib/librte_eal/common/include/rte_vfio.h
++++ b/lib/librte_eal/common/include/rte_vfio.h
More information about the stable
mailing list