patch 'net/failsafe: fix secondary process probe' has been queued to stable release 19.11.11

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Tue Nov 30 17:35:54 CET 2021


Hi,

FYI, your patch has been queued to stable release 19.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before December 10th 2021. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/bb085aa7c14b188e45453f9324f82ca7fcae4c7f

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From bb085aa7c14b188e45453f9324f82ca7fcae4c7f Mon Sep 17 00:00:00 2001
From: Kumara Parameshwaran <kumaraparamesh92 at gmail.com>
Date: Thu, 11 Nov 2021 18:14:58 +0530
Subject: [PATCH] net/failsafe: fix secondary process probe

[ upstream commit 47f5dee19e5f9a2cf1883a7119675d7a25470aca ]

Remove the vdev args check for secondary process which prevents the
secondary from attaching to the device created by the primary process
via the hotplug framework. This check was removed for other vdevs but
was missed for failsafe.

Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process")

Signed-off-by: Kumara Parameshwaran <kumaraparamesh92 at gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/failsafe/failsafe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 72362f35de..978c55007a 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -348,8 +348,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
 	INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s",
 			name);
 
-	if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
-	    strlen(rte_vdev_device_args(vdev)) == 0) {
+	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (!eth_dev) {
 			ERROR("Failed to probe %s", name);
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-30 16:50:14.581719270 +0100
+++ 0150-net-failsafe-fix-secondary-process-probe.patch	2021-11-30 16:50:06.110875878 +0100
@@ -1 +1 @@
-From 47f5dee19e5f9a2cf1883a7119675d7a25470aca Mon Sep 17 00:00:00 2001
+From bb085aa7c14b188e45453f9324f82ca7fcae4c7f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 47f5dee19e5f9a2cf1883a7119675d7a25470aca ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index ad6b43538e..3c754a5f66 100644
+index 72362f35de..978c55007a 100644
@@ -24 +25 @@
-@@ -340,8 +340,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
+@@ -348,8 +348,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)


More information about the stable mailing list