[PATCH 21.11 1/3] Revert "net/i40e: fix jumbo frame Rx with X722"

Kevin Traynor ktraynor at redhat.com
Tue Dec 13 19:47:31 CET 2022


This reverts commit 46abe3043e56f4905972ad87f1bfb15f4c1bc4a2.

This chain of commits has been found to cause issues with setting
max frame size when the link is not negotiated in 1s or the link
is down. The frame size is not set and no error is returned to
the user.

Revert the chain until a fix is found.

Link to original upstream commit and discussion:
719469f13b11 ("net/i40e: fix jumbo frame Rx with X722")
https://mails.dpdk.org/archives/dev/2022-December/257566.html

Reported-by: David Marchand <david.marchand at redhat.com>
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
---
 drivers/net/i40e/i40e_ethdev.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index ecef1a6e7e..bad27355fc 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12115,11 +12115,6 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size)
 	bool can_be_set = true;
 
-	/*
-	 * I40E_MEDIA_TYPE_BASET link up can be ignored
-	 * I40E_MEDIA_TYPE_BASET link down that hw->phy.media_type
-	 * is I40E_MEDIA_TYPE_UNKNOWN
-	 */
-	if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET &&
-	    hw->phy.media_type != I40E_MEDIA_TYPE_UNKNOWN) {
+	/* I40E_MEDIA_TYPE_BASET link up can be ignored */
+	if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET) {
 		do {
 			update_link_reg(hw, &link);
-- 
2.38.1



More information about the stable mailing list