patch 'net/qede: fix redundant condition in debug code' has been queued to stable release 20.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 18 13:37:42 CET 2022
Hi,
FYI, your patch has been queued to stable release 20.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/20/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/793c8206207f54ebaf20c96945edf248c6c503c6
Thanks.
Luca Boccassi
---
>From 793c8206207f54ebaf20c96945edf248c6c503c6 Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Tue, 30 Nov 2021 16:59:13 +0000
Subject: [PATCH] net/qede: fix redundant condition in debug code
[ upstream commit 6caee3fb5f7b45ca7a676d77f678cafc4984defa ]
Expression "a && 1" is equivalent to just "a", so fix the accidental
inclusion of a literal in code.
Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Devendra Singh Rawat <dsinghrawat at marvell.com>
Reviewed-by: Igor Russkikh <irusskikh at marvell.com>
Acked-by: Rasesh Mody <rmody at marvell.com>
---
drivers/net/qede/qede_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
index af86bcc692..9383a6d677 100644
--- a/drivers/net/qede/qede_debug.c
+++ b/drivers/net/qede/qede_debug.c
@@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn,
/* Dump MCP HW Dump */
if (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
- !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1)
+ !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
p_ptt,
dump_buf + offset, dump);
--
2.30.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-02-18 12:37:38.678817892 +0000
+++ 0013-net-qede-fix-redundant-condition-in-debug-code.patch 2022-02-18 12:37:37.518788079 +0000
@@ -1 +1 @@
-From 6caee3fb5f7b45ca7a676d77f678cafc4984defa Mon Sep 17 00:00:00 2001
+From 793c8206207f54ebaf20c96945edf248c6c503c6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6caee3fb5f7b45ca7a676d77f678cafc4984defa ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list