patch 'net/hns3: fix operating queue when TCAM table is invalid' has been queued to stable release 20.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 18 13:38:55 CET 2022
Hi,
FYI, your patch has been queued to stable release 20.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/20/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/3f03bc5d20d519f118a2b105cd877b26103ffecb
Thanks.
Luca Boccassi
---
>From 3f03bc5d20d519f118a2b105cd877b26103ffecb Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Fri, 28 Jan 2022 10:07:07 +0800
Subject: [PATCH] net/hns3: fix operating queue when TCAM table is invalid
[ upstream commit eae97230dc2ab9553cdb335ab9b287a18a1b0c97 ]
Reset queues will query the TCAM table. The table is cleared after global
or imp reset. Currently, PF driver first resets Rx/Tx queues and then
restore the table during the reset recovery process, which will fail to
query the table and trigger a RAS error.
Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop")
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
drivers/net/hns3/hns3_ethdev.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 3c8d41c6c8..b2ff59ef62 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -4598,6 +4598,10 @@ hns3_init_hardware(struct hns3_adapter *hns)
struct hns3_hw *hw = &hns->hw;
int ret;
+ /*
+ * All queue-related HW operations must be performed after the TCAM
+ * table is configured.
+ */
ret = hns3_map_tqp(hw);
if (ret) {
PMD_INIT_LOG(ERR, "Failed to map tqp: %d", ret);
@@ -5374,18 +5378,18 @@ hns3_reinit_dev(struct hns3_adapter *hns)
return ret;
}
+ ret = hns3_init_hardware(hns);
+ if (ret) {
+ hns3_err(hw, "Failed to init hardware: %d", ret);
+ return ret;
+ }
+
ret = hns3_reset_all_tqps(hns);
if (ret) {
hns3_err(hw, "Failed to reset all queues: %d", ret);
return ret;
}
- ret = hns3_init_hardware(hns);
- if (ret) {
- hns3_err(hw, "Failed to init hardware: %d", ret);
- return ret;
- }
-
ret = hns3_enable_hw_error_intr(hns, true);
if (ret) {
hns3_err(hw, "fail to enable hw error interrupts: %d",
--
2.30.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-02-18 12:37:41.189256761 +0000
+++ 0086-net-hns3-fix-operating-queue-when-TCAM-table-is-inva.patch 2022-02-18 12:37:37.782793975 +0000
@@ -1 +1 @@
-From eae97230dc2ab9553cdb335ab9b287a18a1b0c97 Mon Sep 17 00:00:00 2001
+From 3f03bc5d20d519f118a2b105cd877b26103ffecb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit eae97230dc2ab9553cdb335ab9b287a18a1b0c97 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 57f1572340..2641b6f79b 100644
+index 3c8d41c6c8..b2ff59ef62 100644
@@ -24 +25 @@
-@@ -4378,6 +4378,10 @@ hns3_init_hardware(struct hns3_adapter *hns)
+@@ -4598,6 +4598,10 @@ hns3_init_hardware(struct hns3_adapter *hns)
@@ -35 +36 @@
-@@ -5547,18 +5551,18 @@ hns3_reinit_dev(struct hns3_adapter *hns)
+@@ -5374,18 +5378,18 @@ hns3_reinit_dev(struct hns3_adapter *hns)
More information about the stable
mailing list