patch 'net/iavf: fix device stop' has been queued to stable release 21.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/13/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/45e89ed9fdcfef1d525988e97d74a2871505fef3

Thanks.

Kevin

---
>From 45e89ed9fdcfef1d525988e97d74a2871505fef3 Mon Sep 17 00:00:00 2001
From: Radu Nicolau <radu.nicolau at intel.com>
Date: Mon, 23 May 2022 13:04:36 +0100
Subject: [PATCH] net/iavf: fix device stop

[ upstream commit 5933c656b972441718d65275c6bdbec24ee71f9e ]

Move security context destroy from device stop to device close function.
Deleting the context on device stop can prevent the application from
properly cleaning and releasing resources.

Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto")

Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/iavf/iavf_ethdev.c       | 6 +++---
 drivers/net/iavf/iavf_ipsec_crypto.c | 2 --
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 7e7042bd07..a3e66dda9f 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1041,7 +1041,4 @@ iavf_dev_stop(struct rte_eth_dev *dev)
 				  false);
 
-	/* free iAVF security device context all related resources */
-	iavf_security_ctx_destroy(adapter);
-
 	adapter->stopped = 1;
 	dev->data->dev_started = 0;
@@ -2595,4 +2592,7 @@ iavf_dev_close(struct rte_eth_dev *dev)
 	ret = iavf_dev_stop(dev);
 
+	/* free iAVF security device context all related resources */
+	iavf_security_ctx_destroy(adapter);
+
 	iavf_flow_flush(dev, NULL);
 	iavf_flow_uninit(adapter);
diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c b/drivers/net/iavf/iavf_ipsec_crypto.c
index 72ce39a052..fa1cecc1e1 100644
--- a/drivers/net/iavf/iavf_ipsec_crypto.c
+++ b/drivers/net/iavf/iavf_ipsec_crypto.c
@@ -1552,6 +1552,4 @@ iavf_security_ctx_destroy(struct iavf_adapter *adapter)
 		return -ENODEV;
 
-	/* TODO: Add resources cleanup */
-
 	/* free and reset security data structures */
 	rte_free(iavf_sctx);
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-09 12:34:31.275791777 +0100
+++ 0066-net-iavf-fix-device-stop.patch	2022-06-09 12:34:29.808980748 +0100
@@ -1 +1 @@
-From 5933c656b972441718d65275c6bdbec24ee71f9e Mon Sep 17 00:00:00 2001
+From 45e89ed9fdcfef1d525988e97d74a2871505fef3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5933c656b972441718d65275c6bdbec24ee71f9e ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 7a3b37d5e3..e85ae0ed0e 100644
+index 7e7042bd07..a3e66dda9f 100644
@@ -24 +25 @@
-@@ -1089,7 +1089,4 @@ iavf_dev_stop(struct rte_eth_dev *dev)
+@@ -1041,7 +1041,4 @@ iavf_dev_stop(struct rte_eth_dev *dev)
@@ -32,2 +33,2 @@
-@@ -2714,4 +2711,7 @@ iavf_dev_close(struct rte_eth_dev *dev)
- 	adapter->closed = true;
+@@ -2595,4 +2592,7 @@ iavf_dev_close(struct rte_eth_dev *dev)
+ 	ret = iavf_dev_stop(dev);