patch 'dma/idxd: fix error code for PCI device commands' has been queued to stable release 21.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/23/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/8bb9213bbceaef634a7f54cb5775211efdbbaff5

Thanks.

Kevin

---
>From 8bb9213bbceaef634a7f54cb5775211efdbbaff5 Mon Sep 17 00:00:00 2001
From: Kevin Laatz <kevin.laatz at intel.com>
Date: Fri, 8 Apr 2022 15:16:55 +0100
Subject: [PATCH] dma/idxd: fix error code for PCI device commands

[ upstream commit f217dbff20603b51a51e226be77593ea06122ab5 ]

When sending a command to an idxd device via PCI BAR, the response from
HW is checked to ensure it was successful. The response was incorrectly
being negated before being returned by the function, meaning error codes
cannot be checked against the HW specification.

This patch fixes the return values of the function by removing the
negation.

Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check")

Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
Acked-by: Conor Walsh <conor.walsh at intel.com>
---
 drivers/dma/idxd/idxd_pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c
index 9ca1ec64e9..65c6bbf4c1 100644
--- a/drivers/dma/idxd/idxd_pci.c
+++ b/drivers/dma/idxd/idxd_pci.c
@@ -39,5 +39,5 @@ idxd_pci_dev_command(struct idxd_dmadev *idxd, enum rte_idxd_cmds command)
 			rte_spinlock_unlock(&idxd->u.pci->lk);
 			err_code &= CMDSTATUS_ERR_MASK;
-			return -err_code;
+			return err_code;
 		}
 	} while (err_code & CMDSTATUS_ACTIVE_MASK);
@@ -45,5 +45,5 @@ idxd_pci_dev_command(struct idxd_dmadev *idxd, enum rte_idxd_cmds command)
 
 	err_code &= CMDSTATUS_ERR_MASK;
-	return -err_code;
+	return err_code;
 }
 
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-20 10:46:27.898144895 +0100
+++ 0005-dma-idxd-fix-error-code-for-PCI-device-commands.patch	2022-06-20 10:46:27.766146797 +0100
@@ -1 +1 @@
-From f217dbff20603b51a51e226be77593ea06122ab5 Mon Sep 17 00:00:00 2001
+From 8bb9213bbceaef634a7f54cb5775211efdbbaff5 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f217dbff20603b51a51e226be77593ea06122ab5 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org