patch 'net/bnxt: cleanup MTU setting' has been queued to stable release 21.11.2

Kevin Traynor ktraynor at redhat.com
Tue Jun 28 17:19:37 CEST 2022


Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/30/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/44e391b5c233943c7a96c9fc11e87cafb8e28e55

Thanks.

Kevin

---
>From 44e391b5c233943c7a96c9fc11e87cafb8e28e55 Mon Sep 17 00:00:00 2001
From: Damodharam Ammepalli <damodharam.ammepalli at broadcom.com>
Date: Wed, 15 Jun 2022 20:27:02 +0530
Subject: [PATCH] net/bnxt: cleanup MTU setting

[ upstream commit 89670e3b0f852615c29c510d5f6c04d147675c7e ]

Minor cleanup in bnxt_mtu_set_op() to move pre-mature
setting of jumbo flag post mtu check and remove
a redundant mtu set operation from rxq vnic configs.

Fixes: daef48efe5e5 ("net/bnxt: support set MTU")

Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----
 drivers/net/bnxt/bnxt_rxq.c    |  4 ----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 93d17b7670..517e4b3898 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3039,13 +3039,13 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
 		return -ENOTSUP;
 
-	if (new_mtu > RTE_ETHER_MTU)
-		bp->flags |= BNXT_FLAG_JUMBO;
-	else
-		bp->flags &= ~BNXT_FLAG_JUMBO;
-
 	/* Is there a change in mtu setting? */
 	if (eth_dev->data->mtu == new_mtu)
 		return 0;
 
+	if (new_mtu > RTE_ETHER_MTU)
+		bp->flags |= BNXT_FLAG_JUMBO;
+	else
+		bp->flags &= ~BNXT_FLAG_JUMBO;
+
 	for (i = 0; i < bp->nr_vnics; i++) {
 		struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 9b5ff4ce2d..4f2e0e7376 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -404,8 +404,4 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
 	rxq->vnic = BNXT_GET_DEFAULT_VNIC(bp);
 
-	/* Configure mtu if it is different from what was configured before */
-	if (!queue_idx)
-		bnxt_mtu_set_op(eth_dev, eth_dev->data->mtu);
-
 	return 0;
 err:
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-28 16:18:04.643339052 +0100
+++ 0025-net-bnxt-cleanup-MTU-setting.patch	2022-06-28 16:18:04.071387173 +0100
@@ -1 +1 @@
-From 89670e3b0f852615c29c510d5f6c04d147675c7e Mon Sep 17 00:00:00 2001
+From 44e391b5c233943c7a96c9fc11e87cafb8e28e55 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 89670e3b0f852615c29c510d5f6c04d147675c7e ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index f040cdcf94..e275d3a53f 100644
+index 93d17b7670..517e4b3898 100644
@@ -25 +26 @@
-@@ -3038,13 +3038,13 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
+@@ -3039,13 +3039,13 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
@@ -45 +46 @@
-index f4b641773d..fabbbd4560 100644
+index 9b5ff4ce2d..4f2e0e7376 100644
@@ -48 +49 @@
-@@ -403,8 +403,4 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
+@@ -404,8 +404,4 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,



More information about the stable mailing list