patch 'net/sfc: fix memory allocation size for cache' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Tue Mar 1 11:42:15 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/06/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/ae2f030ad19a8b3d452cea3c73422dce35c6ed20

Thanks.

Kevin

---
>From ae2f030ad19a8b3d452cea3c73422dce35c6ed20 Mon Sep 17 00:00:00 2001
From: Weiguo Li <liwg06 at foxmail.com>
Date: Tue, 21 Dec 2021 14:41:22 +0800
Subject: [PATCH] net/sfc: fix memory allocation size for cache

[ upstream commit b0fed38467713807ac03d50ae7c02ef4c320470a ]

The size of unit cache should be sizeof(**cache) instead of
sizeof(*cache). Memory reallocation is inadequate by sizeof(*cache)
for the platform whose size of pointer is 32-bits. Found by coccinelle
(see https://coccinelle.gitlabpages.inria.fr/website) script.

Fixes: 63abf8d29225 ("net/sfc: support SW stats groups")

Signed-off-by: Weiguo Li <liwg06 at foxmail.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 drivers/net/sfc/sfc_sw_stats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sfc/sfc_sw_stats.c b/drivers/net/sfc/sfc_sw_stats.c
index 70259660c0..81f5aa3cc4 100644
--- a/drivers/net/sfc/sfc_sw_stats.c
+++ b/drivers/net/sfc/sfc_sw_stats.c
@@ -778,5 +778,5 @@ sfc_sw_xstats_configure(struct sfc_adapter *sa)
 	memset(*reset_vals, 0, nb_supported * sizeof(**reset_vals));
 
-	*cache = rte_realloc(*cache, cache_count * sizeof(*cache), 0);
+	*cache = rte_realloc(*cache, cache_count * sizeof(**cache), 0);
 	if (*cache == NULL) {
 		rc = ENOMEM;
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-01 10:41:03.007120920 +0000
+++ 0059-net-sfc-fix-memory-allocation-size-for-cache.patch	2022-03-01 10:41:01.345244106 +0000
@@ -1 +1 @@
-From b0fed38467713807ac03d50ae7c02ef4c320470a Mon Sep 17 00:00:00 2001
+From ae2f030ad19a8b3d452cea3c73422dce35c6ed20 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b0fed38467713807ac03d50ae7c02ef4c320470a ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list