patch 'net/mlx5: fix flex item header length translation' has been queued to stable release 21.11.1
Kevin Traynor
ktraynor at redhat.com
Tue Mar 8 15:14:42 CET 2022
Hi,
FYI, your patch has been queued to stable release 21.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/14/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/49180a4530d637de5025003e48b0ebecc57059c0
Thanks.
Kevin
---
>From 49180a4530d637de5025003e48b0ebecc57059c0 Mon Sep 17 00:00:00 2001
From: Gregory Etelson <getelson at nvidia.com>
Date: Tue, 1 Mar 2022 14:28:24 +0200
Subject: [PATCH] net/mlx5: fix flex item header length translation
[ upstream commit 7bda5beead88fbc8717f7cee770bd8d9baf4d20d ]
Flex item API provides support for network header with a fixed and
variable lengths.
When PMD compiles a new flex item object configuration it converts
RTE parameters into matching PMD PARSE_GRAPH parameters and checks
the parameter values against port capabilities.
Current implementation mismatched PARSE_GRAPH configuration fields
for the fixed size header.
Fixes: b293e8e49d78 ("net/mlx5: translate flex item configuration")
Signed-off-by: Gregory Etelson <getelson at nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
drivers/net/mlx5/mlx5_flow_flex.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c
index 9413d4d817..3ef46db1f6 100644
--- a/drivers/net/mlx5/mlx5_flow_flex.c
+++ b/drivers/net/mlx5/mlx5_flow_flex.c
@@ -383,13 +383,9 @@ mlx5_flex_translate_length(struct mlx5_hca_flex_attr *attr,
(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL,
"unsupported header length field mode (FIXED)");
- if (attr->header_length_mask_width < field->field_size)
+ if (field->field_size ||
+ field->offset_mask || field->offset_shift)
return rte_flow_error_set
(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL,
- "header length field width exceeds limit");
- if (field->offset_shift < 0 ||
- field->offset_shift > attr->header_length_mask_width)
- return rte_flow_error_set
- (error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL,
- "invalid header length field shift (FIXED");
+ "invalid fields for fixed mode");
if (field->field_base < 0)
return rte_flow_error_set
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-03-08 13:55:29.110230291 +0000
+++ 0027-net-mlx5-fix-flex-item-header-length-translation.patch 2022-03-08 13:55:28.496315163 +0000
@@ -1 +1 @@
-From 7bda5beead88fbc8717f7cee770bd8d9baf4d20d Mon Sep 17 00:00:00 2001
+From 49180a4530d637de5025003e48b0ebecc57059c0 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7bda5beead88fbc8717f7cee770bd8d9baf4d20d ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 26f0dfa36f..fb08910ddb 100644
+index 9413d4d817..3ef46db1f6 100644
More information about the stable
mailing list