patch 'eal/linux: fix device monitor stop return' has been queued to stable release 21.11.1
Kevin Traynor
ktraynor at redhat.com
Tue Mar 8 15:14:49 CET 2022
Hi,
FYI, your patch has been queued to stable release 21.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/14/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/b399994654309a9d38da071079c0e0e0633ed2a4
Thanks.
Kevin
---
>From b399994654309a9d38da071079c0e0e0633ed2a4 Mon Sep 17 00:00:00 2001
From: Wenxuan Wu <wenxuanx.wu at intel.com>
Date: Fri, 11 Feb 2022 08:41:31 +0000
Subject: [PATCH] eal/linux: fix device monitor stop return
[ upstream commit 4e3582ab5b49aeace3949ea4b9c6b0fddf5097a5 ]
The ret value in rte_dev_event_monitor_stop stands for whether the
monitor has been successfully closed, and should not bind with
rte_intr_callback_unregister, so once it goes to the right exit point of
rte_dev_event_monitor, the ret value should be set to 0.
Also, the refmonitor count has been carefully evaluated, the value
change from 1 to 0, so there is no potential memory leak failure.
Fixes: 1fef6ced07f3 ("eal/linux: allow multiple starts of event monitor")
Signed-off-by: Wenxuan Wu <wenxuanx.wu at intel.com>
---
lib/eal/linux/eal_dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index 851789e85c..52fe336572 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -385,4 +385,5 @@ rte_dev_event_monitor_stop(void)
rte_intr_instance_free(intr_handle);
intr_handle = NULL;
+ ret = 0;
monitor_refcount--;
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-03-08 13:55:29.250879038 +0000
+++ 0034-eal-linux-fix-device-monitor-stop-return.patch 2022-03-08 13:55:28.506315191 +0000
@@ -1 +1 @@
-From 4e3582ab5b49aeace3949ea4b9c6b0fddf5097a5 Mon Sep 17 00:00:00 2001
+From b399994654309a9d38da071079c0e0e0633ed2a4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4e3582ab5b49aeace3949ea4b9c6b0fddf5097a5 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index e6f509bcff..02ae1cde29 100644
+index 851789e85c..52fe336572 100644
@@ -26 +27 @@
-@@ -381,4 +381,5 @@ rte_dev_event_monitor_stop(void)
+@@ -385,4 +385,5 @@ rte_dev_event_monitor_stop(void)
More information about the stable
mailing list