patch 'net/kni: fix config initialization' has been queued to stable release 20.11.5

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Mar 9 17:30:30 CET 2022


Hi,

FYI, your patch has been queued to stable release 20.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/11/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/2de6a2e6269d3b04ff4e6cfd1d6b1bae3cb3b739

Thanks.

Luca Boccassi

---
>From 2de6a2e6269d3b04ff4e6cfd1d6b1bae3cb3b739 Mon Sep 17 00:00:00 2001
From: Harold Huang <baymaxhuang at gmail.com>
Date: Thu, 3 Mar 2022 10:18:03 +0800
Subject: [PATCH] net/kni: fix config initialization

[ upstream commit dcd398f9466fc42f09e5c725c3188d8c41bd3fbf ]

When kni driver calls eth_kni_start to start device, some fields such as
min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause
kni_ioctl_create create a kni netdevice with a random min_mtu and
max_mtu value. This is unexpected and sometimes we could not change the
kni device mtu with ip link command.

Fixes: ff1e35fb5f83 ("kni: calculate MTU from mbuf size")

Signed-off-by: Harold Huang <baymaxhuang at gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/kni/rte_eth_kni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index 5d8fb1451a..5e8d0b722e 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -124,7 +124,7 @@ eth_kni_start(struct rte_eth_dev *dev)
 	struct pmd_internals *internals = dev->data->dev_private;
 	uint16_t port_id = dev->data->port_id;
 	struct rte_mempool *mb_pool;
-	struct rte_kni_conf conf;
+	struct rte_kni_conf conf = {{0}};
 	const char *name = dev->device->name + 4; /* remove net_ */
 
 	mb_pool = internals->rx_queues[0].mb_pool;
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-09 16:30:09.059491129 +0000
+++ 0014-net-kni-fix-config-initialization.patch	2022-03-09 16:30:08.523024617 +0000
@@ -1 +1 @@
-From dcd398f9466fc42f09e5c725c3188d8c41bd3fbf Mon Sep 17 00:00:00 2001
+From 2de6a2e6269d3b04ff4e6cfd1d6b1bae3cb3b739 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit dcd398f9466fc42f09e5c725c3188d8c41bd3fbf ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index c428caf441..0532de5315 100644
+index 5d8fb1451a..5e8d0b722e 100644


More information about the stable mailing list